std::jthread in #410/#411 breaks libc++ consumers — it is an incomplete feature there, and both uses are measurement-only

未关闭
#426 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
android, cmake, cpp

调研方向

Read the two measurement-only uses in src/rtl8733b/Rtl8733bDevice.cpp and src/jaguar1/RtlJaguarDevice.cpp, introduced by #410 and #411, and compare their stop-token polling loops. Reproduce the libc++ build failure with an Android NDK toolchain, noting that r26 lacks the header and r27 requires -fexperimental-library. Done means resolving the libc++ compile failure without imposing an experimental-library requirement on consumers.

由索引模型根据 Issue 内容生成。

描述

Summary

std::jthread / std::stop_token entered the tree in #410 (src/rtl8733b/Rtl8733bDevice.cpp) and #411 (src/jaguar1/RtlJaguarDevice.cpp). devourer asks for cxx_std_20, which is correct in principle — but on libc++ these two are shipped as incomplete features, so a C++20 libc++ toolchain does not provide them by default. Any consumer building devourer against libc++ without -fexperimental-library now fails to compile.

What it looks like

src/jaguar1/RtlJaguarDevice.cpp:1621:8: error: no type named 'jthread' in namespace 'std'; did you mean 'thread'?
src/jaguar1/RtlJaguarDevice.cpp:1635:47: error: no type named 'stop_token' in namespace 'std'

followed by a cascade of variable ... cannot be implicitly captured in a lambda with no capture-default specified from the lambda that was meant to take std::stop_token.

Why the standard level is not the lever

In libc++'s __config:

#  if !defined(_LIBCPP_ENABLE_EXPERIMENTAL) && !defined(_LIBCPP_BUILDING_LIBRARY)
#    define _LIBCPP_HAS_NO_INCOMPLETE_PSTL
#    define _LIBCPP_HAS_NO_EXPERIMENTAL_STOP_TOKEN
...

and __thread/jthread.h is guarded on _LIBCPP_STD_VER >= 20 && !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_STOP_TOKEN). <thread> includes that header unconditionally, so it simply declares no jthread — at any -std= level.

Measured on the Android NDK, which is the case I hit:

NDK libc++ result
r26.3 no <stop_token> header at all cannot build, no flag helps
r27.3 header present, gated builds only with -fexperimental-library

libstdc++ has had jthread since GCC 10, so glibc/GCC targets are unaffected — which is likely why CI is green.

What makes this worth raising

Both uses are measurement-only paths. The Jaguar1 one is reached only when DEVOURER_ACK_DISARM_AFTER_MS is set — the comment above it says "Measurement-only live disarm". So an opt-in debug feature that most consumers will never enable is imposing a libc++-experimental requirement on all of them, at compile time.

Options, in the order I'd suggest

  1. Drop jthread for std::thread + an atomic stop flag. Both sites already poll in a 25 ms quantum loop and already hold a mutex for the real work, so the stop token is buying very little; a std::atomic<bool> plus an explicit join in the same scope is a near-mechanical substitution and removes the dependency outright.
  2. Guard the feature, so the code compiles only where the library has it (#if !defined(_LIBCPP_HAS_NO_EXPERIMENTAL_STOP_TOKEN) or a CMake option). Keeps the feature for the toolchains that can build it.
  3. Document it — state the libc++ requirement and that consumers need -fexperimental-library. Cheapest, but it leaves the trap in place for the next consumer, and a measurement-only path is a surprising thing to pay for.

Happy to send a PR for (1) if you think it is the right shape.

Workaround in the meantime

Target-scoped, from the consumer's own CMake, not a patch to devourer:

if(ANDROID)
    target_compile_options(devourer PRIVATE -fexperimental-library)
endif()

plus NDK r27 or newer — r26 cannot be rescued this way, as the header is absent.

主要语言
C
星标
56
派生
29
平均合并
3 小时 43 分钟
30 天内合并 PR
75

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenIPC/devourer 的其他 Issue

查看 OpenIPC/devourer 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。