Repo - TEST - Cross-check the Fortran 1.6.0 parity fixes against a Fortran GPEC 1.6.0 build

未关闭
#623 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
15/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
领域
testing-qa

调研方向

Start by building the Fortran GPEC 1.6.0 merge at commit 54991242 in a scratch directory, since the gpec/0.0 module predates these fixes. Then translate one Solovev kinetic deck into Fortran inputs and compare ω_D hold, the forced reduction's W_t and resonant fields, and the ν_i, ν_e and lnΛ profile values. Done means a table of quantities with the tolerances at which the two codes agree.

由索引模型根据 Issue 内容生成。

描述

test

#591 asks that the parity fixes that change physics be compared directly with Fortran GPEC 1.6.0 on the same deck. For v2.0, those fixes rely instead on:

  • a line-by-line match to the Fortran diffs;
  • the regression harness, with each moved row explained;
  • for the forced reduction, an instrumented run showing the skipped reduction now fires.

This issue tracks the direct comparison.

Fixes to compare

  • ω_D hold past the bounce midpoint (Fortran PR 288): the kinetic torque on a Solovev kinetic deck.
  • Forced reduction at kinetic crossings, keeping the previous pivot order (Fortran PR 332 and commit 1f8abc54): W_t and the resonant fields.
  • Kinetic-profile floors and pchip fits (Fortran PRs 300 and 336): ν_i, ν_e and lnΛ on a profile with a cold edge node.

Steps

  1. Build Fortran 1.6.0 (the release-1.6.0 merge, 54991242) in a scratch directory. The gpec/0.0 module is a 1.5-era build, from before these fixes.
  2. Translate one Solovev kinetic deck into Fortran inputs.
  3. Compare the quantities above, and record the tolerances that agree.
主要语言
Julia
星标
11
派生
7
平均合并
4 天 1 小时
30 天内合并 PR
68

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenFUSIONToolkit/GPEC 的其他 Issue

查看 OpenFUSIONToolkit/GPEC 的全部 Issue

相似的 Issue

更多 Julia Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。