Test - Check that threaded perturbed-equilibrium loops match serial

未关闭
  • 哪里不对？
#479 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
julia
领域
testing-qa

调研方向

Start by reading the existing regression harness and the threaded loops in PerturbedEquilibrium/SingularCoupling.jl, PerturbedEquilibrium/FieldReconstruction.jl, and KineticForces/Compute.jl. Add a small multi-n Solovev PE test that compares one-thread and multi-thread results, then configure CI with more than one Julia thread. Done means the singular-coupling rows and reconstructed fields are bit-identical; the instability and wall checks can be handled separately.

由索引模型根据 Issue 内容生成。

描述

Problem

CI never sets a thread count, so every @threads loop in PerturbedEquilibrium/SingularCoupling.jl, PerturbedEquilibrium/FieldReconstruction.jl and KineticForces/Compute.jl runs on one thread. The regression harness caches results by commit, not by thread count, so it cannot catch a race either.

Ask

  • Add a test that runs a small multi-n PerturbedEquilibrium (PE) case at 1 thread and at more than 1. It should assert that the singular-coupling rows and the reconstructed fields are bit-identical. diiid_multi_n exercises the repeated-surface path, but a small Solovev multi-n PE case would be cheaper.
  • Run that test in CI with more than one thread (e.g. JULIA_NUM_THREADS=2).

Also missing (could be split out)

PE currently stops only when force_termination is set. It should also refuse to run when:

  • the plasma is unstable (et[1] < 0);
  • the stability run used a wall (wall_settings is not nowall).

Follow-up to #334 and #477.

主要语言
Julia
星标
11
派生
7
平均合并
3 天 14 小时
30 天内合并 PR
69

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

OpenFUSIONToolkit/GPEC 的其他 Issue

查看 OpenFUSIONToolkit/GPEC 的全部 Issue

相似的 Issue

更多 Julia Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。