Replace PrimeNG with Tailwind and our own components

未关闭
  • 哪里不对？
#960 0 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@bracyw 已经在做这个了。

开始于 2026年11月8日。

评估

这个 Issue 还没有评估数据。

描述

by: ai dev work frontend
What

PrimeNG 22 needs a commercial license, and PrimeNG 21 doesn't support Angular 22, so it blocks this epic. #864 settled on replacing it (decision: https://github.com/Northeastern-Electric-Racing/Argos/issues/864#issuecomment-6710745579).

This ticket lands spike #955 on develop:

  • Every route and dialog runs on our own components.
  • Angular Aria and the CDK handle behaviour.
  • Tailwind utilities on a locked set of tokens handle styling.
  • PrimeNG and Angular Material are removed.
Requirements
  • No PrimeNG or Angular Material package, and no stylesheets on rendered components (the unused components are deleted in #962)
  • All 14 routes and their dialogs keep the PrimeNG look. The four open look changes are decided: log row hover, BMS panel titles, charging nub and SoC card height.
  • A WCAG AA audit passes on every route at 390 and 1440 wide: contrast, focus, reflow and target size
  • Total CSS stays at or under 121.8 kB, with no budget raised
  • An ADR and the conventions in docs/CONTEXT.md describe the approach
Notes
  • Where to build: start from the branch 955-try-tailwind-angular-aria-cdk, from spike PR #958 (now closed). It also contains #814's upgrade (PR #879) and #909's Aria/CDK work, so it lands after #814.
  • Dropped approaches:
    • Material (#866): its look and checkbox tree didn't fit.
    • Spartan (#867): no reason was recorded.
    • Taiga (#868): Russian-backed.
    • ng-zorro (#869): no reason was recorded.
    • Fork of PrimeNG 21 (#871): we'd own every future Angular fix.
    • Aria/CDK without Tailwind (#909): carried forward, with Tailwind added on top.
  • Not checked offline: the Mapbox map, which needs a token, and the main landmark on Safari before 17.
  • Open question: should the Playwright audit kit run in CI?
Context transfer
SUMMARY
Spike #955 (PR #958) already migrated every route; this ticket reviews, finishes and lands it after #814.

CONTEXT
- Tokens: src/styles/theme.css (--color-*: initial; AA-vetted only). Recipes: src/ui/recipes/. Primitives: src/ui/.
- Cascade layers: theme, base, vendor, cdk, components, utilities. Mapbox CSS is a non-injected bundle in the vendor layer, linked by the map page. Only the CDK's runtime overlay CSS is unlayered.
- Icons: <ui-icon> (Material Icons font ligatures and registered SVGs); @angular/material uninstalled.
- At 64425612: 547 tests pass; prettier, lint and build pass. Global CSS is 81.7 kB raw / 12.9 kB transfer; Mapbox's CSS (36.4 kB) loads only on /map.
- Traps: classes can't be built from strings; words in comments emit utilities; Angular's Vitest uses isolate:false, so restore window stubs in afterEach.

Generated by Claude Code

主要语言
TypeScript
星标
5
派生
1
平均合并
1 天 8 小时
30 天内合并 PR
35

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

Northeastern-Electric-Racing/Argos 的其他 Issue

查看 Northeastern-Electric-Racing/Argos 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。