Replace PrimeNG with Tailwind and our own components

Đang mở
  • Có gì không ổn?
#960 0 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@bracyw đang làm issue này rồi.

Từ ngày 8/11/2026.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

by: ai dev work frontend
What

PrimeNG 22 needs a commercial license, and PrimeNG 21 doesn't support Angular 22, so it blocks this epic. #864 settled on replacing it (decision: https://github.com/Northeastern-Electric-Racing/Argos/issues/864#issuecomment-6710745579).

This ticket lands spike #955 on develop:

  • Every route and dialog runs on our own components.
  • Angular Aria and the CDK handle behaviour.
  • Tailwind utilities on a locked set of tokens handle styling.
  • PrimeNG and Angular Material are removed.
Requirements
  • No PrimeNG or Angular Material package, and no stylesheets on rendered components (the unused components are deleted in #962)
  • All 14 routes and their dialogs keep the PrimeNG look. The four open look changes are decided: log row hover, BMS panel titles, charging nub and SoC card height.
  • A WCAG AA audit passes on every route at 390 and 1440 wide: contrast, focus, reflow and target size
  • Total CSS stays at or under 121.8 kB, with no budget raised
  • An ADR and the conventions in docs/CONTEXT.md describe the approach
Notes
  • Where to build: start from the branch 955-try-tailwind-angular-aria-cdk, from spike PR #958 (now closed). It also contains #814's upgrade (PR #879) and #909's Aria/CDK work, so it lands after #814.
  • Dropped approaches:
    • Material (#866): its look and checkbox tree didn't fit.
    • Spartan (#867): no reason was recorded.
    • Taiga (#868): Russian-backed.
    • ng-zorro (#869): no reason was recorded.
    • Fork of PrimeNG 21 (#871): we'd own every future Angular fix.
    • Aria/CDK without Tailwind (#909): carried forward, with Tailwind added on top.
  • Not checked offline: the Mapbox map, which needs a token, and the main landmark on Safari before 17.
  • Open question: should the Playwright audit kit run in CI?
Context transfer
SUMMARY
Spike #955 (PR #958) already migrated every route; this ticket reviews, finishes and lands it after #814.

CONTEXT
- Tokens: src/styles/theme.css (--color-*: initial; AA-vetted only). Recipes: src/ui/recipes/. Primitives: src/ui/.
- Cascade layers: theme, base, vendor, cdk, components, utilities. Mapbox CSS is a non-injected bundle in the vendor layer, linked by the map page. Only the CDK's runtime overlay CSS is unlayered.
- Icons: <ui-icon> (Material Icons font ligatures and registered SVGs); @angular/material uninstalled.
- At 64425612: 547 tests pass; prettier, lint and build pass. Global CSS is 81.7 kB raw / 12.9 kB transfer; Mapbox's CSS (36.4 kB) loads only on /map.
- Traps: classes can't be built from strings; words in comments emit utilities; Angular's Vitest uses isolate:false, so restore window stubs in afterEach.

Generated by Claude Code

Ngôn ngữ chính
TypeScript
Star
5
Fork
1
Merge trung bình
1 ngày 8 giờ
Pull request đã merge (30 ngày)
35

Chuẩn bị môi trường

  • Không có Dockerfile hay tệp Docker Compose
  • Có mẫu pull request
  • Không có hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của Northeastern-Electric-Racing/Argos

Tất cả issue của Northeastern-Electric-Racing/Argos

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.