fix(loader-client): the live-reload URL is always http://localhost, so it breaks over LAN and HTTPS
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 68/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- bun, typescript
- 领域
- networking, web-dev
调研方向
Start with apps/client/src/watch.ts and apps/website/src/watch.ts, then trace how the manifest publishes the watch URL and how the website opens the WebSocket. Check how --cert and --key reach the watch server. Done means the published port works from another device over HTTP and HTTPS, with connection logs reflecting the socket's open and close events.
由索引模型根据 Issue 内容生成。
描述
Which app is this bug report for?
client
Issue description
The watch WebSocket server is always plain HTTP, even with --cert/--key, and its URL comes from server.url, which is http://localhost:<port>/ (client watch.ts#L6-L27). The website connects to it as-is (website watch.ts#L9).
$ curl localhost:39171/manifest
{"watch":{"enable":true,"url":"http://localhost:39172/"},...}
- A browser on another device (e.g. a phone testing the game) connects to its own localhost, so live reload never works there.
- On an HTTPS page served from a LAN address, a
ws://connection is mixed content and is blocked by the browser (not tested in a browser). - The website has no
error/closehandler, and logs "Connected to watcher" before the socket is open.
Expected: live reload works from any host the page is served from, over HTTP and HTTPS.
Suggested fix: publish only the watch port; the website builds the URL from location.hostname and uses wss: when the page is HTTPS. Serve the watch socket with the same tls options. Log on open and close.
Found during a read-only audit of main @ 044c766 (2026-11-11).
Code sample
No response
Versions
- @nanoforge-dev/loader-client / @nanoforge-dev/loader-server / @nanoforge-dev/loader-website 1.7.0 (
main@ 044c766) - Bun 1.3.14
- Linux x86_64
Issue priority
Medium (should be fixed soon)
I have tested this issue on a development release
044c766
- 主要语言
- TypeScript
- 星标
- 1
- 派生
- 0
- 平均合并
- 17 小时 25 分钟
- 30 天内合并 PR
- 11
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
NanoForge-dev/Loader 的其他 Issue
-
app:client app:website enhancement refactor
难度 2/5 1-3 小时 新手友好度 72/100
NanoForge-dev/Loader#145 ·
维护者通常 1 天内回复
-
chore(loader-client,loader-server): package.json entry points name files the build does not produce未关闭app:client app:server bug chore good first issue
难度 2/5 1-3 小时 新手友好度 78/100
NanoForge-dev/Loader#144 ·
维护者通常 1 天内回复
-
app:website bug good first issue
难度 2/5 1-3 小时 新手友好度 85/100
NanoForge-dev/Loader#141 ·
维护者通常 1 天内回复
-
app:website bug good first issue
难度 2/5 1-3 小时 新手友好度 82/100
NanoForge-dev/Loader#140 ·
维护者通常 1 天内回复
-
app:server bug
难度 2/5 1-3 小时 新手友好度 85/100
NanoForge-dev/Loader#138 ·
维护者通常 1 天内回复
查看 NanoForge-dev/Loader 的全部 Issue
相似的 Issue
-
Mend: dependency security vulnerability
难度 1/5 1-3 小时 新手友好度 65/100
fdm-monster/fdm-monster#5563 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
be-BOP-io-SA/be-BOP#2849 ·
-
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
难度 2/5 1-3 小时 新手友好度 65/100
growilabs/growi#12246 · 3 条评论 ·
维护者通常 1 天内回复
-
🐛 The Rulekeeper - An index run that gives up on the lock ends Succeeded可能已有人在做 @github-actions 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
SSWConsulting/SSW.Rules#2809 · 1 条评论 ·
维护者通常 1 天内回复