fix(loader-client): the live-reload URL is always http://localhost, so it breaks over LAN and HTTPS
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 68/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- bun, typescript
- 領域
- networking, web-dev
研究方向
Start with apps/client/src/watch.ts and apps/website/src/watch.ts, then trace how the manifest publishes the watch URL and how the website opens the WebSocket. Check how --cert and --key reach the watch server. Done means the published port works from another device over HTTP and HTTPS, with connection logs reflecting the socket's open and close events.
由索引模型根據 Issue 內容生成。
描述
Which app is this bug report for?
client
Issue description
The watch WebSocket server is always plain HTTP, even with --cert/--key, and its URL comes from server.url, which is http://localhost:<port>/ (client watch.ts#L6-L27). The website connects to it as-is (website watch.ts#L9).
$ curl localhost:39171/manifest
{"watch":{"enable":true,"url":"http://localhost:39172/"},...}
- A browser on another device (e.g. a phone testing the game) connects to its own localhost, so live reload never works there.
- On an HTTPS page served from a LAN address, a
ws://connection is mixed content and is blocked by the browser (not tested in a browser). - The website has no
error/closehandler, and logs "Connected to watcher" before the socket is open.
Expected: live reload works from any host the page is served from, over HTTP and HTTPS.
Suggested fix: publish only the watch port; the website builds the URL from location.hostname and uses wss: when the page is HTTPS. Serve the watch socket with the same tls options. Log on open and close.
Found during a read-only audit of main @ 044c766 (2026-11-11).
Code sample
No response
Versions
- @nanoforge-dev/loader-client / @nanoforge-dev/loader-server / @nanoforge-dev/loader-website 1.7.0 (
main@ 044c766) - Bun 1.3.14
- Linux x86_64
Issue priority
Medium (should be fixed soon)
I have tested this issue on a development release
044c766
- 主要語言
- TypeScript
- 星號
- 1
- 分支
- 0
- 平均合併
- 17 小時 25 分鐘
- 30 天內合併 PR
- 11
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
NanoForge-dev/Loader 的其他 Issue
-
app:client app:website enhancement refactor
難度 2/5 1-3 小時 新手友好度 72/100
NanoForge-dev/Loader#145 ·
維護者通常 1 天內回覆
-
chore(loader-client,loader-server): package.json entry points name files the build does not produce未關閉app:client app:server bug chore good first issue
難度 2/5 1-3 小時 新手友好度 78/100
NanoForge-dev/Loader#144 ·
維護者通常 1 天內回覆
-
app:website bug good first issue
難度 2/5 1-3 小時 新手友好度 85/100
NanoForge-dev/Loader#141 ·
維護者通常 1 天內回覆
-
app:website bug good first issue
難度 2/5 1-3 小時 新手友好度 82/100
NanoForge-dev/Loader#140 ·
維護者通常 1 天內回覆
-
app:server bug
難度 2/5 1-3 小時 新手友好度 85/100
NanoForge-dev/Loader#138 ·
維護者通常 1 天內回覆
查看 NanoForge-dev/Loader 的全部 Issue
相似的 Issue
-
Mend: dependency security vulnerability
難度 1/5 1-3 小時 新手友好度 65/100
fdm-monster/fdm-monster#5563 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
be-BOP-io-SA/be-BOP#2849 ·
-
難度 2/5 1-3 小時 新手友好度 79/100
維護者通常 1 天內回覆
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
難度 2/5 1-3 小時 新手友好度 65/100
growilabs/growi#12246 · 3 則留言 ·
維護者通常 1 天內回覆
-
🐛 The Rulekeeper - An index run that gives up on the lock ends Succeeded可能已有人在做 @github-actions 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 72/100
SSWConsulting/SSW.Rules#2809 · 1 則留言 ·
維護者通常 1 天內回覆