Issue hygiene: #1184, #1585 and #1709 are about code that was removed; #1678 names two pool arms that no longer exist

未关闭
  • 哪里不对？
#2,221 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
48/100
Issue 类型
文档
描述清晰度
描述清楚
活跃度
活跃
技术栈
bash, c
领域
tooling

调研方向

Start by checking the cited evidence in Makefile, src/eigenscript.h, and tests/test_temporal_memory.sh, then review issues #1184, #1585, #1709, and #1678. For #1709, run the stated test on a release build with real GNU time. Done means each listed issue is confirmed or refuted in a comment here, obsolete work is closed or rescoped, and #1678 names only surviving arms or is closed with a reason.

由索引模型根据 Issue 内容生成。

描述

area:memory found-by:duet-audit kind:tracking

Read-only audit of the open tracker (audit area 3, issue hygiene) at main e9e5cd60. Three open issues describe code that has since been deleted, so their Done-when boxes can no longer be met as written. A fourth lists build arms that are gone. This issue is the list for a maintainer to close or rescope; nothing here was closed or edited by the audit.

Obsolete: the subject was removed
Issue What it is about Where it went Evidence on main e9e5cd60
#1184 Arena-escape leak in xcalloc/xstrdup in src/arena.c. Box 1 requires a leak report "from xcalloc/xstrdup in src/arena.c" #1699 (9cce9db9, 2026-10-09) removed the bump arena; its message names #1184's class ls src/arena* finds nothing. src/eigenscript.h:12: "The rule removed the Env freelist and the bump arena". tests/sections/0f7b-removed-arena-builtins.sh asserts arena_mark is an undefined name
#1585 Make promote_if_arena cycle-safe and sandbox-budgeted (from closed PR #1578) Same PR #1699: "every promotion/escape branch" removed git grep -n "promote_if_arena|promote_graph|PromoteGraph" -- src prints nothing
#1709 [70d] when_live peak RSS grows under make slot-rehearsal #1726 (431d1932, the arm D flip) deleted the slot-rehearsal variant: "rehearsal semantics are now the only semantics" grep -n "slot-rehearsal|SLOT_REHEARSAL" Makefile and git grep EIGS_SLOT_REHEARSAL -- src print nothing. Since rehearsal semantics are now release semantics, tests/test_temporal_memory.sh was run on a release build of e9e5cd60: 12 passed, 0 failed; when_live 11148 kB at N=200000 and 11152 kB at N=1600000 (+4 kB over 8x). The box had no GNU time, so /usr/bin/time -f %M was replaced by a wrapper printing the child's ru_maxrss; a run with real GNU time should confirm
Rescope: the issue lists arms that no longer exist

#1678 asks for make asan-pool-off-{num,env,callenv,arena} and a CI lane running "the arena and leak sections under each". The env freelist and the arena were removed (src/eigenscript.h:10-17), and the Makefile now has only pool-off-num and pool-off-callenv (Makefile:181-187). No asan-pool-off-num/asan-pool-off-callenv target exists yet, so the issue is still real for those two arms. Its 2026-10-08 comment (a CC= define does not rebuild a populated objdir) also needs rechecking against the per-variant objdirs.

Expected vs actual
  • Expected: an open issue's Done-when can still be met by a change to the current tree.
  • Actual: #1184, #1585 and #1709 can only be closed by deciding they are obsolete; #1678's list is half stale.

Done when

  • #1184, #1585 and #1709 are each closed as not planned (or completed by #1699 / #1726) with a comment naming the removing PR, or reopened with a new Done-when that the current tree can meet.
  • For #1709, bash tests/test_temporal_memory.sh with real GNU time on a release build of main shows when_live peak RSS flat PASS, and that output is in the closing comment.
  • #1678's title and Done-when name only the surviving arms (num, callenv), or it is closed with a reason.
  • found-by:duet-audit hit rate: each item above is marked confirmed or refuted in a comment here.

— Duet (orchestrator)

主要语言
C
星标
3
派生
7
平均合并
6 小时 32 分钟
30 天内合并 PR
285

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。