Issue hygiene: #1184, #1585 and #1709 are about code that was removed; #1678 names two pool arms that no longer exist

Ouverte
  • Quelque chose ne va pas ?
#2,221 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
48/100
Type d'issue
Documentation
Clarté
Clairement spécifiée
Activité
Active
Stack technique
bash, c
Domaine
tooling

Piste de recherche

Start by checking the cited evidence in Makefile, src/eigenscript.h, and tests/test_temporal_memory.sh, then review issues #1184, #1585, #1709, and #1678. For #1709, run the stated test on a release build with real GNU time. Done means each listed issue is confirmed or refuted in a comment here, obsolete work is closed or rescoped, and #1678 names only surviving arms or is closed with a reason.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:memory found-by:duet-audit kind:tracking

Read-only audit of the open tracker (audit area 3, issue hygiene) at main e9e5cd60. Three open issues describe code that has since been deleted, so their Done-when boxes can no longer be met as written. A fourth lists build arms that are gone. This issue is the list for a maintainer to close or rescope; nothing here was closed or edited by the audit.

Obsolete: the subject was removed
Issue What it is about Where it went Evidence on main e9e5cd60
#1184 Arena-escape leak in xcalloc/xstrdup in src/arena.c. Box 1 requires a leak report "from xcalloc/xstrdup in src/arena.c" #1699 (9cce9db9, 2026-10-09) removed the bump arena; its message names #1184's class ls src/arena* finds nothing. src/eigenscript.h:12: "The rule removed the Env freelist and the bump arena". tests/sections/0f7b-removed-arena-builtins.sh asserts arena_mark is an undefined name
#1585 Make promote_if_arena cycle-safe and sandbox-budgeted (from closed PR #1578) Same PR #1699: "every promotion/escape branch" removed git grep -n "promote_if_arena|promote_graph|PromoteGraph" -- src prints nothing
#1709 [70d] when_live peak RSS grows under make slot-rehearsal #1726 (431d1932, the arm D flip) deleted the slot-rehearsal variant: "rehearsal semantics are now the only semantics" grep -n "slot-rehearsal|SLOT_REHEARSAL" Makefile and git grep EIGS_SLOT_REHEARSAL -- src print nothing. Since rehearsal semantics are now release semantics, tests/test_temporal_memory.sh was run on a release build of e9e5cd60: 12 passed, 0 failed; when_live 11148 kB at N=200000 and 11152 kB at N=1600000 (+4 kB over 8x). The box had no GNU time, so /usr/bin/time -f %M was replaced by a wrapper printing the child's ru_maxrss; a run with real GNU time should confirm
Rescope: the issue lists arms that no longer exist

#1678 asks for make asan-pool-off-{num,env,callenv,arena} and a CI lane running "the arena and leak sections under each". The env freelist and the arena were removed (src/eigenscript.h:10-17), and the Makefile now has only pool-off-num and pool-off-callenv (Makefile:181-187). No asan-pool-off-num/asan-pool-off-callenv target exists yet, so the issue is still real for those two arms. Its 2026-10-08 comment (a CC= define does not rebuild a populated objdir) also needs rechecking against the per-variant objdirs.

Expected vs actual
  • Expected: an open issue's Done-when can still be met by a change to the current tree.
  • Actual: #1184, #1585 and #1709 can only be closed by deciding they are obsolete; #1678's list is half stale.

Done when

  • #1184, #1585 and #1709 are each closed as not planned (or completed by #1699 / #1726) with a comment naming the removing PR, or reopened with a new Done-when that the current tree can meet.
  • For #1709, bash tests/test_temporal_memory.sh with real GNU time on a release build of main shows when_live peak RSS flat PASS, and that output is in the closing comment.
  • #1678's title and Done-when name only the surviving arms (num, callenv), or it is closed with a reason.
  • found-by:duet-audit hit rate: each item above is marked confirmed or refuted in a comment here.

— Duet (orchestrator)

Langage dominant
C
Étoiles
3
Forks
7
Merge moyen
6 h 32 min
PR mergées (30 j)
285

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de InauguralSystems/EigenScript

Toutes les issues de InauguralSystems/EigenScript

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.