release: binaries and the ghcr image ship without the MIT license text

未关闭 适合新手
#2,283 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
62/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
c, docker, github-actions
领域
devops

调研方向

先查看 .github/workflows/release.yml 第 173-176 行附近的上传列表,然后查看 .github/actions/release-build/action.yml 第 33 和 43 行,那里只把 src/eigenscript 复制到了构建产物中。对于镜像,检查 Dockerfile 第 32-34 行的最终阶段,并在那里添加 LICENSE。当一次演练运行(dry-run)的产物列表包含许可证,且 docker run --entrypoint cat 输出 MIT 许可证文本时,即完成。

由索引模型根据 Issue 内容生成。

描述

area:ci bug found-by:duet-audit

Found by a read-only license audit (area 12). Facts only; no legal advice.

What is shipped

The two redistributed artifacts carry the executables and stdlib, but not LICENSE:

  • GitHub release assets. .github/actions/release-build/action.yml:33 and :43 copy only src/eigenscript to eigenscript-$ARTIFACT_LABEL / eigenscript-full-$ARTIFACT_LABEL. .github/workflows/release.yml:173-176 uploads eigenscript-*, CHECKSUMS and attestation.sigstore.json. No license file is in the asset list. (GitHub's auto-generated source archives on the same release do contain LICENSE; the binary assets are separate downloads.)
  • Docker image (ghcr.io/<owner>/eigenscript, pushed by .github/workflows/docker.yml:47,58). Dockerfile:32-34 copies eigenscript, eigenlsp and lib/eigenscript into the final stage. LICENSE is not copied. The binaries have no --license output either (src/main.c handles --version only).

Expected vs actual

  • Expected: LICENSE says the copyright and permission notice "shall be included in all copies or substantial portions of the Software", and the copyright line is "InauguralSystems and contributors". There are 105 merged PRs from authors other than the owner account, so the notice is not only the owner's to waive.
  • Actual: someone who downloads a release binary or pulls the image gets the software with no copy of the notice.

make install and install.sh are not in scope here: they run from a clone that already holds LICENSE.

Done when

  • release.yml's upload list includes LICENSE (or each binary ships in an archive that contains it), checked by listing a dry-run's artifacts.
  • The final Docker stage contains the license text: docker run --rm --entrypoint cat <image> /usr/share/doc/eigenscript/LICENSE (or the chosen path) prints the MIT text.
  • A planted removal of the new LICENSE line from either step makes a check fail (or the check is named in this issue if none is added).

— Duet (orchestrator)

主要语言
C
星标
3
派生
7
平均合并
6 小时 16 分钟
30 天内合并 PR
326

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。