Enabling away mode while an alarm is vibrating leaves it running (schedule stops cancelling it)

未关闭
  • 哪里不对？
#28 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
67/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
冷清
技术栈
rust
领域
embedded-iot

调研方向

Read crates/podd-core/src/sensor/manager.rs, especially the RegisteredCommand can_run closures at lines 426–446 and get_alarm_cmd at lines 688–702. Trace how the schedule handles an alarm already running when away mode turns on, then check the relevant scheduler tests or add a focused regression test. Done means the schedule emits the intensity-0 cancel in this case while still preventing the alarm from starting when away mode is on.

由索引模型根据 Issue 内容生成。

描述

bug

The left/right alarm RegisteredCommand can_run closures short-circuit to None whenever away is true: if state.vibration_enabled && !away { get_alarm_cmd(...) } else { None } (crates/podd-core/src/sensor/manager.rs:426-432 and 440-446). get_alarm_cmd is also what emits the intensity-0 cancel when an alarm is running but shouldn't be (manager.rs:688-702). So if an alarm starts (away off) and away mode is then toggled on mid-window, the scheduler never issues the cancel and the alarm keeps vibrating until the firmware's own max-duration timeout. The away-mode gate should still allow the out-of-window/should-not-run cancel path to fire. Double-tap and API ClearAlarm still work, but the schedule no longer stops it.

Filed from a repo-wide code audit (working tree at bcad746).

主要语言
Rust
星标
0
派生
0
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

GoogleBot42/podd 的其他 Issue

查看 GoogleBot42/podd 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。