[Feature]: Count servers that do not run monitor in LinuxGSM Stats

未关闭
#5,204 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
68/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
bash, shell

调研方向

Start by reading info_stats.sh and its call sites in command_monitor.sh (lines 319 and 466), then trace the install opt-in and start flows. Done means opted-in installs report after opting in and after starting, without CPU or RAM values, while the once-a-day limit prevents duplicate reports; update the docs to name the commands that send reports.

由索引模型根据 Issue 内容生成。

描述

command: install command: monitor command: start priority: medium scope: all servers type: feature
Priority

priority: medium

User story

As an admin who opted in to stats but only uses start and stop (a one-off server, an occasional game night, or a LAN or online event), I want that server counted, so that the usage page shows every opted-in install, not only the ones running monitor.

Game

No response

Linux distro

No response

Command

command: install, command: start, command: monitor

Problem statement

info_stats.sh is only called from monitor (command_monitor.sh lines 319 and 466). Admins who run a server once or now and then without a monitor cron job never send a report: one-off servers, occasional game nights, LAN parties and other online or offline events. They are missing from https://linuxgsm.com/data/usage/, so the page only counts servers that run monitor.

Scope and impact

scope: all servers

Further information

Also send the daily report from:

  • install, right after the user opts in to stats.
  • start, after the server has started.

Both should leave out CPU and RAM use: there is none after install, and right after start the values say little.

Since #5198 a report goes out at most once a day per instance, so servers that run monitor send nothing extra. On a day when install or start sends first, the report has no usage values, and monitor sends them from the next day.

GameServerManagers/LinuxGSM-Docs#154 says reports are sent "when stats run". The docs should name the commands that send them.

Alternatives considered
  • stop: the server is still running, so the usage values are real, but with start sending first it would only add a report when a server runs past midnight UTC.
  • details: running it does not mean the server is in use, and anyone who runs it has already installed or started the server.
  • Leave it as is and say in the docs that only servers running monitor are counted.

🤖 Generated with Claude Code

主要语言
Shell
星标
4.9k
派生
866
平均合并
17 小时 58 分钟
30 天内合并 PR
100

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

GameServerManagers/LinuxGSM 的其他 Issue

查看 GameServerManagers/LinuxGSM 的全部 Issue

相似的 Issue

更多 Shell/Bash Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。