[Feature]: Count servers that do not run monitor in LinuxGSM Stats

オープン
#5,204 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
68/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
bash, shell

調査の方向性

Start by reading info_stats.sh and its call sites in command_monitor.sh (lines 319 and 466), then trace the install opt-in and start flows. Done means opted-in installs report after opting in and after starting, without CPU or RAM values, while the once-a-day limit prevents duplicate reports; update the docs to name the commands that send reports.

索引モデルが issue の本文から書いたものです。

説明

command: install command: monitor command: start priority: medium scope: all servers type: feature
Priority

priority: medium

User story

As an admin who opted in to stats but only uses start and stop (a one-off server, an occasional game night, or a LAN or online event), I want that server counted, so that the usage page shows every opted-in install, not only the ones running monitor.

Game

No response

Linux distro

No response

Command

command: install, command: start, command: monitor

Problem statement

info_stats.sh is only called from monitor (command_monitor.sh lines 319 and 466). Admins who run a server once or now and then without a monitor cron job never send a report: one-off servers, occasional game nights, LAN parties and other online or offline events. They are missing from https://linuxgsm.com/data/usage/, so the page only counts servers that run monitor.

Scope and impact

scope: all servers

Further information

Also send the daily report from:

  • install, right after the user opts in to stats.
  • start, after the server has started.

Both should leave out CPU and RAM use: there is none after install, and right after start the values say little.

Since #5198 a report goes out at most once a day per instance, so servers that run monitor send nothing extra. On a day when install or start sends first, the report has no usage values, and monitor sends them from the next day.

GameServerManagers/LinuxGSM-Docs#154 says reports are sent "when stats run". The docs should name the commands that send them.

Alternatives considered
  • stop: the server is still running, so the usage values are real, but with start sending first it would only add a report when a server runs past midnight UTC.
  • details: running it does not mean the server is in use, and anyone who runs it has already installed or started the server.
  • Leave it as is and say in the docs that only servers running monitor are counted.

🤖 Generated with Claude Code

主要言語
Shell
スター
4.9k
フォーク
866
平均マージ
17時間 58分
マージ済み PR(30日)
100

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

GameServerManagers/LinuxGSM のほかの issue

GameServerManagers/LinuxGSM の issue をすべて見る

似ている issue

Shell/Bash の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。