[Feature]: Count servers that do not run monitor in LinuxGSM Stats

Aperta
#5,204 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
68/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
bash, shell

Direzione di ricerca

Start by reading info_stats.sh and its call sites in command_monitor.sh (lines 319 and 466), then trace the install opt-in and start flows. Done means opted-in installs report after opting in and after starting, without CPU or RAM values, while the once-a-day limit prevents duplicate reports; update the docs to name the commands that send reports.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

command: install command: monitor command: start priority: medium scope: all servers type: feature
Priority

priority: medium

User story

As an admin who opted in to stats but only uses start and stop (a one-off server, an occasional game night, or a LAN or online event), I want that server counted, so that the usage page shows every opted-in install, not only the ones running monitor.

Game

No response

Linux distro

No response

Command

command: install, command: start, command: monitor

Problem statement

info_stats.sh is only called from monitor (command_monitor.sh lines 319 and 466). Admins who run a server once or now and then without a monitor cron job never send a report: one-off servers, occasional game nights, LAN parties and other online or offline events. They are missing from https://linuxgsm.com/data/usage/, so the page only counts servers that run monitor.

Scope and impact

scope: all servers

Further information

Also send the daily report from:

  • install, right after the user opts in to stats.
  • start, after the server has started.

Both should leave out CPU and RAM use: there is none after install, and right after start the values say little.

Since #5198 a report goes out at most once a day per instance, so servers that run monitor send nothing extra. On a day when install or start sends first, the report has no usage values, and monitor sends them from the next day.

GameServerManagers/LinuxGSM-Docs#154 says reports are sent "when stats run". The docs should name the commands that send them.

Alternatives considered
  • stop: the server is still running, so the usage values are real, but with start sending first it would only add a report when a server runs past midnight UTC.
  • details: running it does not mean the server is in use, and anyone who runs it has already installed or started the server.
  • Leave it as is and say in the docs that only servers running monitor are counted.

🤖 Generated with Claude Code

Lingua principale
Shell
Stelle
4.9k
Fork
866
Merge medio
17h 58m
PR unite (30g)
100

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di GameServerManagers/LinuxGSM

Tutte le issue di GameServerManagers/LinuxGSM

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.