Structure Library: check, reorganise, π-ligands, navigation
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 18/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- linux, macos
- 领域
- data, desktop-dev, documentation, testing
调研方向
This is a multi-part maintainer plan, not a single task: start by reading the structure files under the SimpleStructures and Ligands folders, and the two found-so-far fixes (2fa576a1, e36bc6aa), to see the file format. The first deliverable is the validation script over all 338 files, run as a test, whose findings are reported before any repair. Done means each listed category is covered and the findings are documented; the layout, ligand split, and navigation changes depend on #325 and should be coordinated with the maintainers first.
由索引模型根据 Issue 内容生成。
描述
Collected from testing on 2026-10-14. One job, after #321 item 9.
1. Check every structure. A validation script over all 338 files, run as a test: bond lengths against covalent radii (missing or extra bonds), valences, overlapping atoms, charge against formula, stray nubs. Found so far by hand: ferrocene bonded Fe to one ring only (fixed in 2fa576a1), NoConverge (a PNNL test case, removed in e36bc6aa). The script's findings are listed before anything is repaired.
2. Layout. The "2" folders (Miscellaneous2, Simple_arenes2, Simple_heterocyclic_compounds2) are alphabetical halves, not topics; Miscellaneous is a mix; ferrocene sits under arenes. Proposed for SimpleStructures: small molecules and solvents; hydrocarbons; alcohols, ethers and carbonyls; acids; arenes; heterocycles; organometallics; natural products (alkaloids, steroids, hormones, vitamins). Teaching: diatomics plus the VSEPR set (SF4, ClF3, PF5, ...). Amino acids, DNA, RNA unchanged.
3. Duplicates and names. Ethene/Ethylene, Acetylene/Ethyne; NH3 and H2O both in Miscellaneous2 and Ligands. Names: Methanole → Methanol, Maleinic_Acid → Maleic acid, h2o, n_Butyric_Acid, Dimethylsulfoxide spelling.
4. Ligands split in two.
- "Ligands (σ-donors)": a nub on each donor atom (bipy, acac, en, phen, PPh3, PMe3, CO, CN⁻, NH3, H2O, pyridine, oxalate), with abbreviations in the names.
- New "π-ligands", no nubs, η in each name: Cp⁻ (η5), Cp*⁻ (η5), indenyl⁻ (η5/η3), benzene, hexamethylbenzene, p-cymene (η6), C7H7⁺ (η7), COT²⁻ (η8), allyl⁻ (η3), 1,3-butadiene (η4), ethene (η2), acetylene and diphenylacetylene (η2), COD and NBD (2 × η2), dba (η2). Each with a test that it attaches with that hapticity (#325).
- Check first that Greek letters and superscripts in folder and file names display on Linux, Windows and macOS; otherwise ASCII ("Pi ligands", "eta5").
5. Hapticity rule extension (#325). A picked atom in a planar conjugated sp2 chain bonds the whole chain (allyl η3, butadiene η4); isolated C=C stay η2 (COD, NBD: two attachments, one nub each).
6. Navigation. The Structure Library's drop-down lists only the top-level categories: inside SimpleStructures/Simple_arenes it offers RNA, DNA etc., not the other SimpleStructures subfolders. Replace with a tree (folders expandable) or a two-level choice, and add a search field matching names and abbreviations (Cp, acac, bipy, COD).
7. Help: update pages that name library folders (Molecules for teaching).
- 主要语言
- C
- 星标
- 10
- 派生
- 8
- 平均合并
- 21 分钟
- 30 天内合并 PR
- 1
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
FriendsofECCE/ECCE 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
FriendsofECCE/ECCE#336 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 25/100
FriendsofECCE/ECCE#339 ·
-
难度 4/5 3-5 天 新手友好度 28/100
FriendsofECCE/ECCE#338 · 2 条评论 ·
-
Basis Set Tool: periodic table cut off on the right; elements 110-118 still have placeholder names未关闭
难度 4/5 3-5 天 新手友好度 40/100
FriendsofECCE/ECCE#337 ·
-
难度 5/5 一周以上 新手友好度 8/100
FriendsofECCE/ECCE#335 ·
查看 FriendsofECCE/ECCE 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
immortalwrt/immortalwrt#2501 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
taisei-project/taisei#454 ·
-
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
-
area:gates bug good first issue
难度 1/5 1 小时以内 新手友好度 85/100
InauguralSystems/EigenScript#1782 ·
维护者通常 1 天内回复