Builder: metal–π bonds cannot be made to ring carbons (Metal order still needs nubs)
还没有人认领这个 Issue。
评估
调研方向
Start in Fragment::bondAtoms and BondEditCmd, where Builder bonds currently go between two nubs, then check how addBond is reached in Bond mode with the Metal order. The change lets a Metal bond join two picked atoms directly without consuming nubs or hydrogens, while the align prompt for two molecules keeps working. Done when Fe(PPh3)3 plus benzene gets six Metal bonds to ring carbons with no change in atom count, and ferrocene can be built from two Cp⁻ rings. The typo fix ("unambigously") is part of the same change.
由索引模型根据 Issue 内容生成。
描述
Seen: ECCE 9.1.0. A tetrahedral Fe with three PPh3, then a benzene from the Structure Library. Inserting benzene: "Cannot unambigously connect fragments. Please select the sites that should be bonded." Bond mode with the Metal (metal–π) order, Fe to a ring carbon: "No bond sites are available to create this bond."
Cause: every bond the Builder makes goes between two nubs (Fragment::bondAtoms, BondEditCmd), including the Metal order (0.5). Ring carbons of benzene, Cp⁻ or an alkene have no nub (all valences used), so a metal–π bond to them cannot be made. Elsewhere the Builder already treats Metal bonds as not counting toward valence (shape and hydrogen placement ignore them), so requiring nubs here is inconsistent.
Fix: a Metal bond neither needs nor consumes nubs: in Bond mode with the Metal order, the two picked atoms are bonded directly (addBond), and nubs and hydrogens of both atoms stay as they are. With two molecules, the align question keeps working as now. Test: Fe(PPh3)3 + benzene, six Metal bonds to the ring carbons, no change in atom count; ferrocene from two Cp⁻.
Also: "unambigously" in the first message → "unambiguously".
- 主要语言
- C
- 星标
- 10
- 派生
- 8
- 平均合并
- 21 分钟
- 30 天内合并 PR
- 1
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
FriendsofECCE/ECCE 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
FriendsofECCE/ECCE#336 · 1 条评论 ·
-
难度 5/5 一周以上 新手友好度 35/100
FriendsofECCE/ECCE#370 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 48/100
FriendsofECCE/ECCE#369 · 2 条评论 ·
-
难度 5/5 一周以上 新手友好度 35/100
FriendsofECCE/ECCE#368 ·
-
难度 5/5 一周以上 新手友好度 25/100
FriendsofECCE/ECCE#367 · 2 条评论 ·
查看 FriendsofECCE/ECCE 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
FujiNetWIFI/fujinet-firmware#2079 ·
维护者通常 1 天内回复
-
bug
难度 1/5 1 小时以内 新手友好度 84/100
VirusTotal/yara#2255 ·
-
难度 2/5 1-3 小时 新手友好度 66/100
-
state:needs triage
难度 2/5 1-3 小时 新手友好度 78/100
zed-industries/zed#65836 · 1 个 reaction ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
neutralinojs/neutralinojs#1861 ·
维护者通常 1 天内回复