Builder: metal–π bonds cannot be made to ring carbons (Metal order still needs nubs)
還沒有人認領這個 Issue。
評估
研究方向
Start in Fragment::bondAtoms and BondEditCmd, where Builder bonds currently go between two nubs, then check how addBond is reached in Bond mode with the Metal order. The change lets a Metal bond join two picked atoms directly without consuming nubs or hydrogens, while the align prompt for two molecules keeps working. Done when Fe(PPh3)3 plus benzene gets six Metal bonds to ring carbons with no change in atom count, and ferrocene can be built from two Cp⁻ rings. The typo fix ("unambigously") is part of the same change.
由索引模型根據 Issue 內容生成。
描述
Seen: ECCE 9.1.0. A tetrahedral Fe with three PPh3, then a benzene from the Structure Library. Inserting benzene: "Cannot unambigously connect fragments. Please select the sites that should be bonded." Bond mode with the Metal (metal–π) order, Fe to a ring carbon: "No bond sites are available to create this bond."
Cause: every bond the Builder makes goes between two nubs (Fragment::bondAtoms, BondEditCmd), including the Metal order (0.5). Ring carbons of benzene, Cp⁻ or an alkene have no nub (all valences used), so a metal–π bond to them cannot be made. Elsewhere the Builder already treats Metal bonds as not counting toward valence (shape and hydrogen placement ignore them), so requiring nubs here is inconsistent.
Fix: a Metal bond neither needs nor consumes nubs: in Bond mode with the Metal order, the two picked atoms are bonded directly (addBond), and nubs and hydrogens of both atoms stay as they are. With two molecules, the align question keeps working as now. Test: Fe(PPh3)3 + benzene, six Metal bonds to the ring carbons, no change in atom count; ferrocene from two Cp⁻.
Also: "unambigously" in the first message → "unambiguously".
- 主要語言
- C
- 星號
- 10
- 分支
- 8
- 平均合併
- 21 分鐘
- 30 天內合併 PR
- 1
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
FriendsofECCE/ECCE 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 70/100
FriendsofECCE/ECCE#336 · 1 則留言 ·
-
難度 4/5 3-5 天 新手友好度 25/100
FriendsofECCE/ECCE#339 ·
-
難度 4/5 3-5 天 新手友好度 28/100
FriendsofECCE/ECCE#338 · 2 則留言 ·
-
Basis Set Tool: periodic table cut off on the right; elements 110-118 still have placeholder names未關閉
難度 4/5 3-5 天 新手友好度 40/100
FriendsofECCE/ECCE#337 ·
-
難度 5/5 一週以上 新手友好度 8/100
FriendsofECCE/ECCE#335 ·
查看 FriendsofECCE/ECCE 的全部 Issue
相似的 Issue
-
[BUG] Small issues on iMXRT found by Claude可能已有人在做 @Sarthak-Pandey 今天認領。 未關閉Arch: arm Area: Networking OS: Linux Type: Bug
難度 2/5 1-3 小時 新手友好度 66/100
維護者通常 1 天內回覆
-
area: docs eco: cpp good first issue help wanted lane: free-agent roadmap size: XS type: docs
難度 2/5 1-3 小時 新手友好度 70/100
arminazimi/evergreen#475 ·
維護者通常 1 天內回覆
-
[Issue]: hipsparselt.h C API as shipped now requires C23 -- ONLY because of missing include or guard未關閉
難度 2/5 1-3 小時 新手友好度 62/100
ROCm/rocm-libraries#13736 ·
維護者通常 2 天內回覆
-
libc
難度 2/5 1-3 小時 新手友好度 78/100
llvm/llvm-project#232380 · 1 則留言 ·
維護者通常 1 天內回覆
-
level/task module/auth/enrollment platform/linux reporter/qa type/bug
難度 2/5 1-3 小時 新手友好度 66/100
維護者通常 1 天內回覆