pls improve map validation tool (upload vs server pathing)
还没有人认领这个 Issue。
评估
调研方向
从 /maps/validate 端点开始，比较上传版本和服务器创建版本的 map-name 与 scenario.lua 路径验证输出。结合上传流程确认预期的文件夹约定，然后定义应如何选择这两种模式，以及一致的验证输出和上传行为意味着什么。
由索引模型根据 Issue 内容生成。
描述
First of all, I love our new validation tool: https://api.faforever.com/maps/validate
But I found some Issues that should be improved...
Validate Map Name
The map name validation for Adaptive Map says adaptive_map.v0001 for the folder.
-
That folder name and path is created while map upload and in
FAF Editor -
server created version=/maps/adaptive_map.v0001/adaptive_map.scmap
Validate scenario.lua
But in the validation of the obviously wrong path in the scenario content, it gives you a folder path without .v0001 /maps/adaptive_map/adaptive_map.scmap
-
As far as I know, that path is created in
GPG Editorand needed to be applied for map upload (without .v0001 in folder and file path)? Please correct me if I'm wrong. -
upload version=/maps/adaptive_map/adaptive_map.scmap
Conclusion
FAF Editor version = server created version = /maps/adaptive_map.v0001/adaptive_map.scmap
GPG Editor version = upload version = /maps/adaptive_map/adaptive_map.scmap
That's why I think, the tool is confusing how it is now and leads to maps not being able to load. It would be nice to clarify if an upload version or an server created version should be validated.
It would be nice to give both options to a map maker. And validate consistently over name and scenario validation, like in picture 2#. A checkbox could be a solution to enable the map maker to get the right information. Because I really like to prevent issues like this while uploading:
Bad example
1# difference in validated name and scenario folder naming
Good example
2# example for constant folder naming with .v0001 like in the server created version
One additional question
Isn't it possible to also allow an upload with the version number in the folder?
That would be awesome. This way there is no difference between GPG Editor and FAF Editor maps and both can simply be uploaded. No broken files due to upload process ;)
- 主要语言
- Java
- 星标
- 31
- 派生
- 30
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
FAForever/faf-java-api 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 48/100
FAForever/faf-java-api#1182 · 3 条评论 ·
-
Replay review requests from the client, via the api and RabbitMQ可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 5/5 一周以上 新手友好度 25/100
FAForever/faf-java-api#1181 · 12 条评论 ·
-
难度 3/5 1-2 天 新手友好度 30/100
FAForever/faf-java-api#895 ·
-
难度 5/5 一周以上 新手友好度 30/100
FAForever/faf-java-api#816 ·
-
难度 5/5 一周以上 新手友好度 30/100
FAForever/faf-java-api#708 · 13 条评论 ·
查看 FAForever/faf-java-api 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
-
account bug communication lecture
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
area/server bug P2
难度 2/5 1-3 小时 新手友好度 68/100
modelcontextprotocol/java-sdk#1196 ·
维护者通常 1 天内回复