Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

An unset ADMIN_TOKEN disables the admin surface silently

已关闭
  • 哪里不对？
#508 6 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 2 天内回复

@dev-RAM11 已经在做这个了。

开始于 2026年10月19日。

  • #566 来自 @sparkysolutions10-pixel —— 未关闭
  • #601 来自 @dev-RAM11 —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
api, authentication, documentation

调研方向

Start with src/api/auth.ts and trace how ADMIN_TOKEN is checked and where startup configuration and /status or /ready are handled. Read src/tests/auth.test.ts and run npx vitest run src/__tests__/auth.test.ts; also check .env.example and the repository's drift guard for src/. Done means unset and wrong-token cases are distinguishable without exposing the expected value, startup and status make the disabled state visible, and the unset case is tested.

由索引模型根据 Issue 内容生成。

描述

area:config difficulty:easy help wanted points:100 Stellar Wave
Background
function isAdminAuthorized(req: FastifyRequest): boolean {
  const adminToken = process.env.ADMIN_TOKEN
  if (!adminToken) return false
  ...

Failing closed is right — an unset token must never mean "allow everyone". But
it fails closed silently: the service starts normally, and every admin route
returns the same 401 as a wrong token. An operator who forgot the variable, or
typoed its name, sees "Provide a valid X-Admin-Token header" and goes looking
for a problem with their token.

What to build
  • Log clearly at startup when ADMIN_TOKEN is not configured, saying the admin
    surface is disabled.
  • Distinguish the two cases in the response: a wrong token is not the same as a
    server with no token configured. Say "not configured" without revealing
    anything about the expected value.
  • Surface it on /status or /ready so it is visible without reading logs.
  • Document the variable in .env.example with what it gates. The repo's drift
    guard covers src/, so check it is there.
  • Consider rejecting a trivially weak token at startup — an empty string after
    trimming, or an obvious placeholder.
Acceptance criteria
  • Startup logs that admin routes are disabled when the token is unset
  • "Not configured" and "wrong token" are distinguishable to an operator
  • Neither response reveals anything about the expected value
  • .env.example documents the variable and what it gates
  • A test covers the unset case

Drips Wave · Complexity: Easy · 100 points

Repo: Divinity-Labs/Lens. Auth is src/api/auth.ts, key minting
src/api/admin.ts, usage reporting src/api/usage.ts, metering
src/x402/metering.ts, the ApiKey model in prisma/schema.prisma.

Run the tests: npm test. The tests are vitest, not jest. A single file
is npx vitest run src/__tests__/auth.test.ts.

Load test (prices) is already failing on main. Not your PR.

Do not weaken what is already right. Three things are correct today and
should survive every change here:

  • generateApiKey() is lens_ plus randomBytes(24) — 192 bits. Do not
    shorten it, and do not make it guessable or sequential.
  • hashApiKey() is an unsalted SHA-256. That is correct for a
    high-entropy random key: it must stay fast and deterministic so a lookup is
    one indexed query. Do not "improve" it into bcrypt or argon2 — those are for
    low-entropy human passwords, and here they would only make every request slow.
  • Only the hash is ever stored. The plaintext is returned once, at creation,
    and never again.

Admin routes carry config: { public: true }. That does not mean public —
it means "skip the API-key hook", because they enforce ADMIN_TOKEN instead.
Removing that flag locks the admin surface behind the keys it exists to mint.

Never elide an address, a key or a token in code, comments, tests or
documentation. Write it in full or not at all — and never write a real key
anywhere.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要语言
TypeScript
星标
4
派生
71
平均合并
2 天 20 小时
30 天内合并 PR
127

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

Divinity-Labs/Lens 的其他 Issue

查看 Divinity-Labs/Lens 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。