Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

An unset ADMIN_TOKEN disables the admin surface silently

クローズ
  • 何か問題がありますか？
#508 コメント 6 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

@dev-RAM11 がすでに取り組んでいます。

2026年10月19日 から。

  • #566 @sparkysolutions10-pixel による — オープン
  • #601 @dev-RAM11 による — オープン

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
55/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript
領域
api, authentication, documentation

調査の方向性

Start with src/api/auth.ts and trace how ADMIN_TOKEN is checked and where startup configuration and /status or /ready are handled. Read src/tests/auth.test.ts and run npx vitest run src/__tests__/auth.test.ts; also check .env.example and the repository's drift guard for src/. Done means unset and wrong-token cases are distinguishable without exposing the expected value, startup and status make the disabled state visible, and the unset case is tested.

索引モデルが issue の本文から書いたものです。

説明

area:config difficulty:easy help wanted points:100 Stellar Wave
Background
function isAdminAuthorized(req: FastifyRequest): boolean {
  const adminToken = process.env.ADMIN_TOKEN
  if (!adminToken) return false
  ...

Failing closed is right — an unset token must never mean "allow everyone". But
it fails closed silently: the service starts normally, and every admin route
returns the same 401 as a wrong token. An operator who forgot the variable, or
typoed its name, sees "Provide a valid X-Admin-Token header" and goes looking
for a problem with their token.

What to build
  • Log clearly at startup when ADMIN_TOKEN is not configured, saying the admin
    surface is disabled.
  • Distinguish the two cases in the response: a wrong token is not the same as a
    server with no token configured. Say "not configured" without revealing
    anything about the expected value.
  • Surface it on /status or /ready so it is visible without reading logs.
  • Document the variable in .env.example with what it gates. The repo's drift
    guard covers src/, so check it is there.
  • Consider rejecting a trivially weak token at startup — an empty string after
    trimming, or an obvious placeholder.
Acceptance criteria
  • Startup logs that admin routes are disabled when the token is unset
  • "Not configured" and "wrong token" are distinguishable to an operator
  • Neither response reveals anything about the expected value
  • .env.example documents the variable and what it gates
  • A test covers the unset case

Drips Wave · Complexity: Easy · 100 points

Repo: Divinity-Labs/Lens. Auth is src/api/auth.ts, key minting
src/api/admin.ts, usage reporting src/api/usage.ts, metering
src/x402/metering.ts, the ApiKey model in prisma/schema.prisma.

Run the tests: npm test. The tests are vitest, not jest. A single file
is npx vitest run src/__tests__/auth.test.ts.

Load test (prices) is already failing on main. Not your PR.

Do not weaken what is already right. Three things are correct today and
should survive every change here:

  • generateApiKey() is lens_ plus randomBytes(24) — 192 bits. Do not
    shorten it, and do not make it guessable or sequential.
  • hashApiKey() is an unsalted SHA-256. That is correct for a
    high-entropy random key: it must stay fast and deterministic so a lookup is
    one indexed query. Do not "improve" it into bcrypt or argon2 — those are for
    low-entropy human passwords, and here they would only make every request slow.
  • Only the hash is ever stored. The plaintext is returned once, at creation,
    and never again.

Admin routes carry config: { public: true }. That does not mean public —
it means "skip the API-key hook", because they enforce ADMIN_TOKEN instead.
Removing that flag locks the admin surface behind the keys it exists to mint.

Never elide an address, a key or a token in code, comments, tests or
documentation. Write it in full or not at all — and never write a real key
anywhere.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
2日 20時間
マージ済み PR（30日）
127

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。