Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

An unset ADMIN_TOKEN disables the admin surface silently

Chiusa
  • Qualcosa non va?
#508 6 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@dev-RAM11 ci sta già lavorando.

Dal 19/10/2026.

  • #566 di @sparkysolutions10-pixel — aperta
  • #601 di @dev-RAM11 — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
api, authentication, documentation

Direzione di ricerca

Start with src/api/auth.ts and trace how ADMIN_TOKEN is checked and where startup configuration and /status or /ready are handled. Read src/tests/auth.test.ts and run npx vitest run src/__tests__/auth.test.ts; also check .env.example and the repository's drift guard for src/. Done means unset and wrong-token cases are distinguishable without exposing the expected value, startup and status make the disabled state visible, and the unset case is tested.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:config difficulty:easy help wanted points:100 Stellar Wave
Background
function isAdminAuthorized(req: FastifyRequest): boolean {
  const adminToken = process.env.ADMIN_TOKEN
  if (!adminToken) return false
  ...

Failing closed is right — an unset token must never mean "allow everyone". But
it fails closed silently: the service starts normally, and every admin route
returns the same 401 as a wrong token. An operator who forgot the variable, or
typoed its name, sees "Provide a valid X-Admin-Token header" and goes looking
for a problem with their token.

What to build
  • Log clearly at startup when ADMIN_TOKEN is not configured, saying the admin
    surface is disabled.
  • Distinguish the two cases in the response: a wrong token is not the same as a
    server with no token configured. Say "not configured" without revealing
    anything about the expected value.
  • Surface it on /status or /ready so it is visible without reading logs.
  • Document the variable in .env.example with what it gates. The repo's drift
    guard covers src/, so check it is there.
  • Consider rejecting a trivially weak token at startup — an empty string after
    trimming, or an obvious placeholder.
Acceptance criteria
  • Startup logs that admin routes are disabled when the token is unset
  • "Not configured" and "wrong token" are distinguishable to an operator
  • Neither response reveals anything about the expected value
  • .env.example documents the variable and what it gates
  • A test covers the unset case

Drips Wave · Complexity: Easy · 100 points

Repo: Divinity-Labs/Lens. Auth is src/api/auth.ts, key minting
src/api/admin.ts, usage reporting src/api/usage.ts, metering
src/x402/metering.ts, the ApiKey model in prisma/schema.prisma.

Run the tests: npm test. The tests are vitest, not jest. A single file
is npx vitest run src/__tests__/auth.test.ts.

Load test (prices) is already failing on main. Not your PR.

Do not weaken what is already right. Three things are correct today and
should survive every change here:

  • generateApiKey() is lens_ plus randomBytes(24) — 192 bits. Do not
    shorten it, and do not make it guessable or sequential.
  • hashApiKey() is an unsalted SHA-256. That is correct for a
    high-entropy random key: it must stay fast and deterministic so a lookup is
    one indexed query. Do not "improve" it into bcrypt or argon2 — those are for
    low-entropy human passwords, and here they would only make every request slow.
  • Only the hash is ever stored. The plaintext is returned once, at creation,
    and never again.

Admin routes carry config: { public: true }. That does not mean public —
it means "skip the API-key hook", because they enforce ADMIN_TOKEN instead.
Removing that flag locks the admin surface behind the keys it exists to mint.

Never elide an address, a key or a token in code, comments, tests or
documentation. Write it in full or not at all — and never write a real key
anywhere.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lingua principale
TypeScript
Stelle
4
Fork
71
Merge medio
2g 20h
PR unite (30g)
127

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Divinity-Labs/Lens

Tutte le issue di Divinity-Labs/Lens

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.