Distinguish upcoming peer review from a closed evaluation window (CMP drift)

未关闭
#523 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
django, playwright, python
领域
backend, testing

调研方向

Read _docs/specs/04-courses-and-cohorts.md, _docs/specs/02-url-link-seo-compatibility.md, and _docs/specs/10-verification-strategy.md, then inspect courses/views/project_eval.py and courses/templates/projects/eval.html. Trace the existing state and cohort date presentation helpers before adjusting the upcoming, open, and completed branches. Done means the focused Django state/auth matrix and applicable Playwright checks pass while preserving the listed access, privacy, and route behavior.

由索引模型根据 Issue 内容生成。

描述

bug courses frontend P2

Problem and provenance

The website describes every project outside PEER_REVIEWING as closed; learners see an incorrect closed-window message before review starts. CMP #290, commit 3256766, and #291, commit 89ea396, distinguish upcoming from completed review and show timing to anonymous visitors too. Intake 835873e9-5f63-4e5d-b0f9-0773e1d562b6 authorizes small PRs and candidate-only delivery.

Authority

  • _docs/specs/04-courses-and-cohorts.md: preserved project review behavior, cohort-specific assessment ownership, canonical cohort routes and private review responses.
  • _docs/specs/02-url-link-seo-compatibility.md: canonical course/cohort routes.
  • _docs/specs/10-verification-strategy.md; _docs/ci/change-selective-ci.md.

Scope

Adapt the two CMP changes to courses/views/project_eval.py and the website design-system template courses/templates/projects/eval.html. On /courses/<family>/<identifier>/projects/<project>/eval use an explicit not-open state for CLOSED and COLLECTING_SUBMISSIONS; PEER_REVIEWING remains open, COMPLETED remains closed. Display the available peer-review start/deadline using existing cohort dates and presentation helpers. Keep anonymous sign-in guidance while also showing upcoming timing. Never change grading, assignment, scoring or authorization state.

Acceptance criteria

  • CLOSED and COLLECTING_SUBMISSIONS projects show that peer review has not opened yet, for anonymous visitors and authenticated learners with or without a submission; do not incorrectly say the review form is closed.
  • Available review start/deadline timing is presented with the existing date/time conventions; missing timing renders safe readable copy without broken or invented dates.
  • PEER_REVIEWING preserves required and volunteer review navigation and learner-specific context. COMPLETED preserves closed-window behavior.
  • GET remains read-only; cohort isolation, login destinations and private/no-store response policy remain covered.
  • Focused Django state/auth matrix and applicable Playwright checks pass; independent tester captures and inspects desktop/mobile screenshots for upcoming anonymous and authenticated states and verifies existing open/completed branches.
  • Generate exact base/head verification plan; independent tester and PM acceptance; required checks green on the PR exact head before merge; candidate-only deployment verified at prod.datatalks.club.

Non-goals and boundaries

No new timeline/state machine, emails, schedules, migrations, shared-package changes or rollout to current datatalks.club. CMP is read-only; courses.datatalks.club, join.datatalks.club, signup emails and Slack settings stay unchanged. No real-user emails. No dependency on the other drift ports.

主要语言
Python
星标
0
派生
0
平均合并
37 分钟
30 天内合并 PR
36

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

DataTalksClub/website 的其他 Issue

查看 DataTalksClub/website 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。