Distinguish upcoming peer review from a closed evaluation window (CMP drift)

Aperta
#523 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
django, playwright, python
Ambito
backend, testing

Direzione di ricerca

Read _docs/specs/04-courses-and-cohorts.md, _docs/specs/02-url-link-seo-compatibility.md, and _docs/specs/10-verification-strategy.md, then inspect courses/views/project_eval.py and courses/templates/projects/eval.html. Trace the existing state and cohort date presentation helpers before adjusting the upcoming, open, and completed branches. Done means the focused Django state/auth matrix and applicable Playwright checks pass while preserving the listed access, privacy, and route behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug courses frontend P2

Problem and provenance

The website describes every project outside PEER_REVIEWING as closed; learners see an incorrect closed-window message before review starts. CMP #290, commit 3256766, and #291, commit 89ea396, distinguish upcoming from completed review and show timing to anonymous visitors too. Intake 835873e9-5f63-4e5d-b0f9-0773e1d562b6 authorizes small PRs and candidate-only delivery.

Authority

  • _docs/specs/04-courses-and-cohorts.md: preserved project review behavior, cohort-specific assessment ownership, canonical cohort routes and private review responses.
  • _docs/specs/02-url-link-seo-compatibility.md: canonical course/cohort routes.
  • _docs/specs/10-verification-strategy.md; _docs/ci/change-selective-ci.md.

Scope

Adapt the two CMP changes to courses/views/project_eval.py and the website design-system template courses/templates/projects/eval.html. On /courses/<family>/<identifier>/projects/<project>/eval use an explicit not-open state for CLOSED and COLLECTING_SUBMISSIONS; PEER_REVIEWING remains open, COMPLETED remains closed. Display the available peer-review start/deadline using existing cohort dates and presentation helpers. Keep anonymous sign-in guidance while also showing upcoming timing. Never change grading, assignment, scoring or authorization state.

Acceptance criteria

  • CLOSED and COLLECTING_SUBMISSIONS projects show that peer review has not opened yet, for anonymous visitors and authenticated learners with or without a submission; do not incorrectly say the review form is closed.
  • Available review start/deadline timing is presented with the existing date/time conventions; missing timing renders safe readable copy without broken or invented dates.
  • PEER_REVIEWING preserves required and volunteer review navigation and learner-specific context. COMPLETED preserves closed-window behavior.
  • GET remains read-only; cohort isolation, login destinations and private/no-store response policy remain covered.
  • Focused Django state/auth matrix and applicable Playwright checks pass; independent tester captures and inspects desktop/mobile screenshots for upcoming anonymous and authenticated states and verifies existing open/completed branches.
  • Generate exact base/head verification plan; independent tester and PM acceptance; required checks green on the PR exact head before merge; candidate-only deployment verified at prod.datatalks.club.

Non-goals and boundaries

No new timeline/state machine, emails, schedules, migrations, shared-package changes or rollout to current datatalks.club. CMP is read-only; courses.datatalks.club, join.datatalks.club, signup emails and Slack settings stay unchanged. No real-user emails. No dependency on the other drift ports.

Lingua principale
Python
Stelle
0
Fork
0
Merge medio
37m
PR unite (30g)
36

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DataTalksClub/website

Tutte le issue di DataTalksClub/website

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.