AWS installer (beta): two uninstall report lines claim more than they show

未关闭
#1,381 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
aws, python
领域
cli, cloud, testing

调研方向

Start with the controlvar-aws uninstall reporting code and the installer fakes used by its tests. Locate the FAILED block and the logic that counts tag-index entries, including how resources intentionally retained by uninstall are distinguished from resources still being cleared. Update both report behaviors and add focused fake-based tests that fail against the current wording and exclude retained resources from the clearing count.

由索引模型根据 Issue 内容生成。

描述

bug post-launch

Two lines in controlvar-aws uninstall's report say something that is not true in the case they print in. Both were
seen on a real AWS run of the beta.

  1. "Nothing else the install made is in your account" is printed in the FAILED block even when a line under "Not
    explained" is something the install made (for example the cache's automatic backup, while AWS is still deleting
    it). The sentence should not claim more than the report shows: either drop it when anything is unexplained, or
    say that the unexplained lines may include the install's own leftovers.

  2. " tag-index entries AWS is still clearing (minutes to hours)", after uninstalling an install that stopped
    before its stacks, counted the tag-index entries of the CDK's setup stack, which the uninstall keeps on purpose and
    which therefore never clear. Tag-index entries of resources the uninstall keeps should not be counted as clearing.

Each fix needs a test on the installer's fakes that fails on today's wording. Both lines are in the same part of the
uninstall's report as the fix for the cache's automatic backup, so this follows that change.

主要语言
Python
星标
0
派生
4
平均合并
5 小时 19 分钟
30 天内合并 PR
503

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Controlvar/controlvar 的其他 Issue

查看 Controlvar/controlvar 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。