AWS installer (beta): two uninstall report lines claim more than they show

オープン
#1,381 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
72/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
aws, python
領域
cli, cloud, testing

調査の方向性

Start with the controlvar-aws uninstall reporting code and the installer fakes used by its tests. Locate the FAILED block and the logic that counts tag-index entries, including how resources intentionally retained by uninstall are distinguished from resources still being cleared. Update both report behaviors and add focused fake-based tests that fail against the current wording and exclude retained resources from the clearing count.

索引モデルが issue の本文から書いたものです。

説明

bug post-launch

Two lines in controlvar-aws uninstall's report say something that is not true in the case they print in. Both were
seen on a real AWS run of the beta.

  1. "Nothing else the install made is in your account" is printed in the FAILED block even when a line under "Not
    explained" is something the install made (for example the cache's automatic backup, while AWS is still deleting
    it). The sentence should not claim more than the report shows: either drop it when anything is unexplained, or
    say that the unexplained lines may include the install's own leftovers.

  2. " tag-index entries AWS is still clearing (minutes to hours)", after uninstalling an install that stopped
    before its stacks, counted the tag-index entries of the CDK's setup stack, which the uninstall keeps on purpose and
    which therefore never clear. Tag-index entries of resources the uninstall keeps should not be counted as clearing.

Each fix needs a test on the installer's fakes that fails on today's wording. Both lines are in the same part of the
uninstall's report as the fix for the cache's automatic backup, so this follows that change.

主要言語
Python
スター
0
フォーク
4
平均マージ
5時間 19分
マージ済み PR(30日)
503

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Controlvar/controlvar のほかの issue

Controlvar/controlvar の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。