Feature-flag changes can be saved without a compliance audit entry; state the audit log's durability per resource

未关闭 适合新手
#1,042 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
72/100
Issue 类型
文档
描述清晰度
基本清楚
活跃度
活跃
技术栈
python

调研方向

从 backend/app/api/v1/endpoints/feature_flags.py 开始,然后将其审计写入行为与 docs/api/endpoints.md 中描述的事务保证进行比较。还要阅读威胁模型表和 docs/architecture/overview.md 中关于审计日志的说明。完成意味着文档清楚说明每个资源的持久性保证,并针对尽力而为的审计条目说明遗漏的条目可通过现有的审计失败指标观察到。

由索引模型根据 Issue 内容生成。

描述

enhancement post-launch

Feature-flag create, update and delete write their compliance audit entry after the flag change has been committed, and a failure to write it is logged and ignored (backend/app/api/v1/endpoints/feature_flags.py, e.g. lines ~364-384: "non-fatal: do not fail the request if this fails"). So a flag change can be saved with no compliance audit entry. User administration is different: docs/api/endpoints.md states that its audit entry is written in the same transaction and that nothing is saved if it cannot be written.

The docs describe the audit log as an "immutable audit trail" (the threat-model table and docs/architecture/overview.md), which readers can take to mean complete.

Expected: state the durability promise per resource. Either write the flag's audit entry in the same transaction (as user administration does), or say in the audit-logging docs which changes are recorded best-effort and how a missed entry is visible (the existing audit-failure metric). Found in a code review (2026-10-06).

主要语言
Python
星标
0
派生
4
平均合并
6 小时 5 分钟
30 天内合并 PR
453

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Controlvar/controlvar 的其他 Issue

查看 Controlvar/controlvar 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。