Start and log error (rather than refusing to start) if -settings flag points to nonexistent file
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
调研方向
The payload does not name the file, so begin by finding where the -settings command-line argument is parsed and where the settings file is loaded at startup. Reproduce by launching Phoebus with a path that does not exist and note where it exits. Done means startup continues with the normal defaults and logs an error that includes the missing path, with the change covered by a test if one exists for settings loading.
由索引模型根据 Issue 内容生成。
描述
We are looking to use a base settings.ini file with all the 'defaults', and then override some settings per machine. One option is to distribute multiple versions of Phoebus with different settings.ini files, but this is a pain in many ways.
So seemingly the easiest way to do this is to have our default settings in the install directory (which guarantees they will always be loaded), and then to pass -settings <path>/overrides.ini to the application when it is launched. This works, except that if the file passed to -settings is not found, Phoebus will refuse to start. Since we don't want to force every user to create an empty overrides.ini file, the ideal solution is that Phoebus still starts, and instead logs an error if the file is not found. This seems like more useful functionality in general anyway - from the code it seems like the -settings flag is meant to work as an override
This would be a simple case of adding a try-catch around the relevant code
- 主要语言
- Java
- 星标
- 130
- 派生
- 132
- 平均合并
- 2 天 11 小时
- 30 天内合并 PR
- 19
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
ControlSystemStudio/phoebus 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
ControlSystemStudio/phoebus#3983 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
ControlSystemStudio/phoebus#3979 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
ControlSystemStudio/phoebus#3962 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
ControlSystemStudio/phoebus#3865 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 52/100
ControlSystemStudio/phoebus#3980 ·
维护者通常 2 天内回复
查看 ControlSystemStudio/phoebus 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
checkstyle/checkstyle#22153 ·
维护者通常 1 天内回复
-
Documentation Needs Triage
难度 1/5 1 小时以内 新手友好度 78/100
frankframework/frankframework#11908 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
ome/ome-codecs#48 ·
-
难度 1/5 1 小时以内 新手友好度 90/100
tonihele/OpenKeeper#672 ·
维护者通常 4 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
eclipse-ee4j/angus-mail#224 ·