Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

feat(atemschutz): the retreat rule is a flat 50 bar — the Einstiegsdruck never enters it, and bar is a literal not a unit

未关闭
  • 哪里不对？
#402 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp, sqlite
领域
backend, database, mobile

调研方向

Start by reading src/LageBuch.Domain/Atemschutz/AtemschutzTrupp.cs, ScbaViewModel.cs, and the PressureReading and RecordScbaPressureCommand definitions; then inspect the schema, PDF output, and AtemschutzTests noted in the issue. The issue frames this as a milestone requiring domain decisions and cross-cutting changes, not a newcomer-sized task. Done would require an agreed pressure-unit and alarm-rule design, with tests deliberately covering the new semantics and preserving the default behavior.

由索引模型根据 Issue 内容生成。

描述

enhancement

From a portability review of main (ecb341b). The largest single item that review turned up; filing it for the record rather than proposing it be done soon.

What the rule is today

// src/LageBuch.Domain/Atemschutz/AtemschutzTrupp.cs
public const int DefaultReturnPressureBar = 50;                 // :31
public bool IsPressureAlarm => (IsActive || IsWithdrawing)      // :328
    && LatestPressure is { } p && p <= ReturnPressureBar;

A flat absolute comparison against a per-Trupp scalar seeded from IncidentSettings.ReturnPressureBar. There is no computed retreat pressure anywhere in the repo — no two-thirds rule, no reserve calculation, no cylinder-volume or consumption model. Greps for 2/3, Zweidrittel, Reserve, Flasche find nothing.

Two consequences

Entry pressure is captured but never used. Register demands an Einstiegsdruck and validates it (:117-162), and then it plays no part in any alarm. A Trupp starting at 200 bar and one starting at 300 bar alarm at the same 50 bar, having consumed very different fractions of their air. The Einstiegsdruck is documentation only.

Whether that is wrong for German practice is a question for someone who teaches Atemschutz, not for me — a fixed Rückzugsdruck is a defensible and widely taught rule, and it is configurable per install. Flagging it because the captured-but-unused input looks like an unfinished thought rather than a decision.

bar is not a unit, it is a literal. PressureReading is (DateTimeOffset Time, int Bar); the sync command is RecordScbaPressureCommand(Guid TruppId, int Bar); the column is return_pressure_bar; the master-data key is return_pressure_bar; and " bar" is concatenated as a string suffix in nine places across the UI, the PDF and the domain exception message (:349). There is no conversion path.

Also hardcoded rather than configured: the 300-bar entry default is a UI literal (ScbaViewModel.cs:228,524), so a brigade on 200-bar sets retypes it on every registration; MaxPressureBar = 400 (:33); and the pressure-check interval defaults to a third of the Einsatzzeit (ScbaViewModel.cs:376-382) rather than to the domain's own DefaultPressureControlIntervalMinutes.

Why this blocks any use outside the German doctrine

A fixed bar threshold cannot express either of the two rules used in the English-speaking fire services: UK BA entry control computes a time-of-whistle from cylinder pressure and consumption rate, and NFPA 1404's rule of air management is a fraction (leave by one third remaining). Neither is a constant.

Shape of a fix, if it is ever wanted

  • a pressure unit on IncidentSettings (bar/psi) with display and validation derived from it, rather than a literal suffix;
  • entry pressure as a first-class input to the alarm rule;
  • the rule itself selected from { absolute threshold, fraction of entry pressure, time-based }, defaulting to the current absolute behaviour so no existing install changes.

This touches PressureReading, the sync command, the schema, the PDF and AtemschutzTests (:211-226 pins the current semantics and would be rewritten deliberately, not adjusted). It is a milestone, not a PR.

主要语言
C#
星标
1
派生
3
平均合并
4 小时 34 分钟
30 天内合并 PR
182

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

CodeForFire/lagebuch 的其他 Issue

查看 CodeForFire/lagebuch 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。