feat(atemschutz): the retreat rule is a flat 50 bar — the Einstiegsdruck never enters it, and bar is a literal not a unit
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
調査の方向性
Start by reading src/LageBuch.Domain/Atemschutz/AtemschutzTrupp.cs, ScbaViewModel.cs, and the PressureReading and RecordScbaPressureCommand definitions; then inspect the schema, PDF output, and AtemschutzTests noted in the issue. The issue frames this as a milestone requiring domain decisions and cross-cutting changes, not a newcomer-sized task. Done would require an agreed pressure-unit and alarm-rule design, with tests deliberately covering the new semantics and preserving the default behavior.
索引モデルが issue の本文から書いたものです。
説明
From a portability review of main (ecb341b). The largest single item that review turned up; filing it for the record rather than proposing it be done soon.
What the rule is today
// src/LageBuch.Domain/Atemschutz/AtemschutzTrupp.cs
public const int DefaultReturnPressureBar = 50; // :31
public bool IsPressureAlarm => (IsActive || IsWithdrawing) // :328
&& LatestPressure is { } p && p <= ReturnPressureBar;
A flat absolute comparison against a per-Trupp scalar seeded from IncidentSettings.ReturnPressureBar. There is no computed retreat pressure anywhere in the repo — no two-thirds rule, no reserve calculation, no cylinder-volume or consumption model. Greps for 2/3, Zweidrittel, Reserve, Flasche find nothing.
Two consequences
Entry pressure is captured but never used. Register demands an Einstiegsdruck and validates it (:117-162), and then it plays no part in any alarm. A Trupp starting at 200 bar and one starting at 300 bar alarm at the same 50 bar, having consumed very different fractions of their air. The Einstiegsdruck is documentation only.
Whether that is wrong for German practice is a question for someone who teaches Atemschutz, not for me — a fixed Rückzugsdruck is a defensible and widely taught rule, and it is configurable per install. Flagging it because the captured-but-unused input looks like an unfinished thought rather than a decision.
bar is not a unit, it is a literal. PressureReading is (DateTimeOffset Time, int Bar); the sync command is RecordScbaPressureCommand(Guid TruppId, int Bar); the column is return_pressure_bar; the master-data key is return_pressure_bar; and " bar" is concatenated as a string suffix in nine places across the UI, the PDF and the domain exception message (:349). There is no conversion path.
Also hardcoded rather than configured: the 300-bar entry default is a UI literal (ScbaViewModel.cs:228,524), so a brigade on 200-bar sets retypes it on every registration; MaxPressureBar = 400 (:33); and the pressure-check interval defaults to a third of the Einsatzzeit (ScbaViewModel.cs:376-382) rather than to the domain's own DefaultPressureControlIntervalMinutes.
Why this blocks any use outside the German doctrine
A fixed bar threshold cannot express either of the two rules used in the English-speaking fire services: UK BA entry control computes a time-of-whistle from cylinder pressure and consumption rate, and NFPA 1404's rule of air management is a fraction (leave by one third remaining). Neither is a constant.
Shape of a fix, if it is ever wanted
- a pressure unit on
IncidentSettings(bar/psi) with display and validation derived from it, rather than a literal suffix; - entry pressure as a first-class input to the alarm rule;
- the rule itself selected from
{ absolute threshold, fraction of entry pressure, time-based }, defaulting to the current absolute behaviour so no existing install changes.
This touches PressureReading, the sync command, the schema, the PDF and AtemschutzTests (:211-226 pins the current semantics and would be rewritten deliberately, not adjusted). It is a milestone, not a PR.
- 主要言語
- C#
- スター
- 1
- フォーク
- 3
- 平均マージ
- 4時間 49分
- マージ済み PR（30日）
- 177
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
CodeForFire/lagebuch のほかの issue
-
Stammdaten: in the Checkliste editor the PFLICHT header is not aligned with its column対応中かも @Saad-elnagar が 1 日前に担当しました。 オープンbug ux
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
CodeForFire/lagebuch#714 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Stammdaten: on a phone the Fahrzeuge editor squeezes Wache and Funkrufname to nothing対応中かも @Saad-elnagar が 1 日前に担当しました。 オープンbug ux
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
CodeForFire/lagebuch#713 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
CodeForFire/lagebuch#405 ·
メンテナーはふだん 1 日以内に返信
-
documentation good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
CodeForFire/lagebuch#349 ·
メンテナーはふだん 1 日以内に返信
-
documentation good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
CodeForFire/lagebuch#348 ·
メンテナーはふだん 1 日以内に返信
CodeForFire/lagebuch の issue をすべて見る
似ている issue
-
bug effort:S P2
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
nightscout/nocturne#2449 ·
メンテナーはふだん 1 日以内に返信
-
area: client bug
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
bug mcp misleading small
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
hazeliscoding/gil-sweep#25 ·
メンテナーはふだん 1 日以内に返信