Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

feat(atemschutz): the retreat rule is a flat 50 bar — the Einstiegsdruck never enters it, and bar is a literal not a unit

Abierto
  • ¿Algo no está bien?
#402 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp, sqlite
Área
backend, database, mobile

Línea de trabajo

Start by reading src/LageBuch.Domain/Atemschutz/AtemschutzTrupp.cs, ScbaViewModel.cs, and the PressureReading and RecordScbaPressureCommand definitions; then inspect the schema, PDF output, and AtemschutzTests noted in the issue. The issue frames this as a milestone requiring domain decisions and cross-cutting changes, not a newcomer-sized task. Done would require an agreed pressure-unit and alarm-rule design, with tests deliberately covering the new semantics and preserving the default behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

From a portability review of main (ecb341b). The largest single item that review turned up; filing it for the record rather than proposing it be done soon.

What the rule is today

// src/LageBuch.Domain/Atemschutz/AtemschutzTrupp.cs
public const int DefaultReturnPressureBar = 50;                 // :31
public bool IsPressureAlarm => (IsActive || IsWithdrawing)      // :328
    && LatestPressure is { } p && p <= ReturnPressureBar;

A flat absolute comparison against a per-Trupp scalar seeded from IncidentSettings.ReturnPressureBar. There is no computed retreat pressure anywhere in the repo — no two-thirds rule, no reserve calculation, no cylinder-volume or consumption model. Greps for 2/3, Zweidrittel, Reserve, Flasche find nothing.

Two consequences

Entry pressure is captured but never used. Register demands an Einstiegsdruck and validates it (:117-162), and then it plays no part in any alarm. A Trupp starting at 200 bar and one starting at 300 bar alarm at the same 50 bar, having consumed very different fractions of their air. The Einstiegsdruck is documentation only.

Whether that is wrong for German practice is a question for someone who teaches Atemschutz, not for me — a fixed Rückzugsdruck is a defensible and widely taught rule, and it is configurable per install. Flagging it because the captured-but-unused input looks like an unfinished thought rather than a decision.

bar is not a unit, it is a literal. PressureReading is (DateTimeOffset Time, int Bar); the sync command is RecordScbaPressureCommand(Guid TruppId, int Bar); the column is return_pressure_bar; the master-data key is return_pressure_bar; and " bar" is concatenated as a string suffix in nine places across the UI, the PDF and the domain exception message (:349). There is no conversion path.

Also hardcoded rather than configured: the 300-bar entry default is a UI literal (ScbaViewModel.cs:228,524), so a brigade on 200-bar sets retypes it on every registration; MaxPressureBar = 400 (:33); and the pressure-check interval defaults to a third of the Einsatzzeit (ScbaViewModel.cs:376-382) rather than to the domain's own DefaultPressureControlIntervalMinutes.

Why this blocks any use outside the German doctrine

A fixed bar threshold cannot express either of the two rules used in the English-speaking fire services: UK BA entry control computes a time-of-whistle from cylinder pressure and consumption rate, and NFPA 1404's rule of air management is a fraction (leave by one third remaining). Neither is a constant.

Shape of a fix, if it is ever wanted

  • a pressure unit on IncidentSettings (bar/psi) with display and validation derived from it, rather than a literal suffix;
  • entry pressure as a first-class input to the alarm rule;
  • the rule itself selected from { absolute threshold, fraction of entry pressure, time-based }, defaulting to the current absolute behaviour so no existing install changes.

This touches PressureReading, the sync command, the schema, the PDF and AtemschutzTests (:211-226 pins the current semantics and would be rewritten deliberately, not adjusted). It is a milestone, not a PR.

Lenguaje dominante
C#
Estrellas
1
Forks
3
Merge medio
4 h 34 min
PR fusionados (30 d)
182

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de CodeForFire/lagebuch

Todos los issues de CodeForFire/lagebuch

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.