Replace the timetable filter pills with one Filters button and popover
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 42/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- react, typescript
调研方向
Start with ViewTimeTable.tsx, FacultySelector.tsx, and the Figma frame “Timetable filters” (node 2560:1371); check the open work on #266, #283, and #262 before editing. Build the Filters button, popover, active filter tags, and clear/remove interactions while keeping faculty and same-building behavior. Done when the design and listed interactions work; coordinate the remaining timetable logic with #289.
由索引模型根据 Issue 内容生成。
描述
Scroll down for design
Is your feature request related to a problem? Please describe.
Next to "Your Timetables" there are Morning, Evening and Mixed pills, a Same Building checkbox and a Filter by Faculty box. They take a lot of room and each one is a separate control.
Describe the solution you'd like
One Filters button replaces all of them. Pressing it opens a popover.
- A count badge on the button shows how many filters are on.
- Popover options:
- Theory time (Morning, Evening, Mixed)
- Class time: a range bar with two handles that snap to class start and end times, with the times shown under the handles
- Fewest lab days
- Same building
- A faculty field
- Clear all
- Active filters show as small removable tags beside "Your Timetables", and the × removes one.
- Same building and the faculty field keep working as they do today, just moved into the popover. How the other options pick and order timetables is in the logic issue (#289).
Additional context
Related: #187 (filter by multiple faculties), #188 (filter by slots) and #263 (same-building filtering), all closed.
ViewTimeTable.tsx is changing in other work, so expect merge conflicts:
- #266 (open): splits
FacultySelector.tsxandViewTimeTable.tsxinto smaller modules. - #283 (open PR): changes timetable state in
ViewTimeTable.tsx. - #262 (open): changes the saved-timetable local storage syncing in the same file.
- #267 (merged): groups timetables with the same slot layout. The tags and counts must still refer to the real timetable selection.
Design
- Figma frame:
Timetable filters(node2560:1371) on the page "FFCS revamp". It contains theFilters button, theFilters popoverand theActive filtersrow. - Link: https://www.figma.com/design/uCP8B7drfprKgsHYjB8sYs?node-id=2560-1371
- The Figma frame still shows the old Fewest 8 am / Fewest 7:20 pm options; the range bar replaces them.
Example
One way to build it (just an idea):
ZButtonfor the Filters button- A popover built like the other popups
- The existing faculty
ComboBoxfor the faculty field
<ZButton type="regular" text={`Filters${count ? ` (${count})` : ''}`} onClick={togglePopover} />
{open && <FiltersPopover value={filters} onChange={setFilters} onClear={clearAll} />}
- 主要语言
- TypeScript
- 星标
- 6
- 派生
- 37
- 平均合并
- 11 小时 13 分钟
- 30 天内合并 PR
- 55
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
CodeChefVIT/ffcs 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 55/100
CodeChefVIT/ffcs#295 ·
维护者通常 1 天内回复
-
难度 4/5 1-2 天 新手友好度 48/100
CodeChefVIT/ffcs#292 ·
维护者通常 1 天内回复
-
Edit a course from Your Courses with a pencil button可能已有人在做 @Aiden-Trindade 于 2 天前认领。 未关闭
难度 5/5 一周以上 新手友好度 43/100
CodeChefVIT/ffcs#291 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Put the selection box and Your Courses side by side and restyle them可能已有人在做 @Aiden-Trindade 于 2 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 55/100
CodeChefVIT/ffcs#290 · 已指派 1 人 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 43/100
CodeChefVIT/ffcs#289 ·
维护者通常 1 天内回复
相似的 Issue
-
area:cli bug P4
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
bug from-studio
难度 2/5 1-3 小时 新手友好度 65/100
esengine/DeepSeek-Reasonix#14868 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
linxiv-dev/linXiv#384 · 1 条评论 ·
维护者通常 1 天内回复
-
factory-active task-identify-harness-labels-done task-identify-issue-type-done
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复