Replace the timetable filter pills with one Filters button and popover
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 42/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- react, typescript
研究方向
Start with ViewTimeTable.tsx, FacultySelector.tsx, and the Figma frame “Timetable filters” (node 2560:1371); check the open work on #266, #283, and #262 before editing. Build the Filters button, popover, active filter tags, and clear/remove interactions while keeping faculty and same-building behavior. Done when the design and listed interactions work; coordinate the remaining timetable logic with #289.
由索引模型根據 Issue 內容生成。
描述
Scroll down for design
Is your feature request related to a problem? Please describe.
Next to "Your Timetables" there are Morning, Evening and Mixed pills, a Same Building checkbox and a Filter by Faculty box. They take a lot of room and each one is a separate control.
Describe the solution you'd like
One Filters button replaces all of them. Pressing it opens a popover.
- A count badge on the button shows how many filters are on.
- Popover options:
- Theory time (Morning, Evening, Mixed)
- Class time: a range bar with two handles that snap to class start and end times, with the times shown under the handles
- Fewest lab days
- Same building
- A faculty field
- Clear all
- Active filters show as small removable tags beside "Your Timetables", and the × removes one.
- Same building and the faculty field keep working as they do today, just moved into the popover. How the other options pick and order timetables is in the logic issue (#289).
Additional context
Related: #187 (filter by multiple faculties), #188 (filter by slots) and #263 (same-building filtering), all closed.
ViewTimeTable.tsx is changing in other work, so expect merge conflicts:
- #266 (open): splits
FacultySelector.tsxandViewTimeTable.tsxinto smaller modules. - #283 (open PR): changes timetable state in
ViewTimeTable.tsx. - #262 (open): changes the saved-timetable local storage syncing in the same file.
- #267 (merged): groups timetables with the same slot layout. The tags and counts must still refer to the real timetable selection.
Design
- Figma frame:
Timetable filters(node2560:1371) on the page "FFCS revamp". It contains theFilters button, theFilters popoverand theActive filtersrow. - Link: https://www.figma.com/design/uCP8B7drfprKgsHYjB8sYs?node-id=2560-1371
- The Figma frame still shows the old Fewest 8 am / Fewest 7:20 pm options; the range bar replaces them.
Example
One way to build it (just an idea):
ZButtonfor the Filters button- A popover built like the other popups
- The existing faculty
ComboBoxfor the faculty field
<ZButton type="regular" text={`Filters${count ? ` (${count})` : ''}`} onClick={togglePopover} />
{open && <FiltersPopover value={filters} onChange={setFilters} onClear={clearAll} />}
- 主要語言
- TypeScript
- 星號
- 6
- 分支
- 37
- 平均合併
- 11 小時 13 分鐘
- 30 天內合併 PR
- 55
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
CodeChefVIT/ffcs 的其他 Issue
-
難度 4/5 3-5 天 新手友好度 55/100
CodeChefVIT/ffcs#295 ·
維護者通常 1 天內回覆
-
難度 4/5 1-2 天 新手友好度 48/100
CodeChefVIT/ffcs#292 ·
維護者通常 1 天內回覆
-
Edit a course from Your Courses with a pencil button可能已有人在做 @Aiden-Trindade 於 2 天前認領。 未關閉
難度 5/5 一週以上 新手友好度 43/100
CodeChefVIT/ffcs#291 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
Put the selection box and Your Courses side by side and restyle them可能已有人在做 @Aiden-Trindade 於 2 天前認領。 未關閉
難度 4/5 3-5 天 新手友好度 55/100
CodeChefVIT/ffcs#290 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 43/100
CodeChefVIT/ffcs#289 ·
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 66/100
CopilotKit/openmuse#215 ·
維護者通常 3 天內回覆
-
b:minor bug
難度 2/5 1-3 小時 新手友好度 76/100
software-mansion/argent#1698 ·
維護者通常 1 天內回覆
-
e2e-failure ready-to-code
難度 2/5 1-3 小時 新手友好度 72/100
redhat-developer/rhdh-plugin-export-overlays#4624 · 1 則留言 ·
維護者通常 1 天內回覆