Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Go proxy allows websocket attach (GET /containers/{name}/attach/ws), giving stdin access to containers

未关闭
  • 哪里不对？
#76 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
docker, go, rust, typescript
领域
api, backend, security

调研方向

Start with the Go router and go/internal/proxy/transport.go, then compare the Rust and TypeScript transports. Read spec/router.qnt and the existing execNeverAllowed rule; add coverage in the three router tables and an integration check for the websocket upgrade. Done means attach paths are denied across methods and the upgrade receives the proxy's 403 in all three implementations.

由索引模型根据 Issue 内容生成。

描述

Priority: P0 Type: Bug

Describe the bug
The Go proxy lets a client write to a container's stdin through a websocket attach: GET /containers/{name}/attach/ws?stdin=1&stream=1 with Upgrade: websocket. The router treats it as a read (GET passthrough), and go/internal/proxy/transport.go (httputil.ReverseProxy) passes the protocol upgrade through, so the client gets a bidirectional stream to the container. Attaching to a container whose main process is a shell is equivalent to exec, which the proxy exists to deny. This holds with and without --readonly.

Found in the review of the #75 fix (fix/readonly-router-75); not introduced by it.

Affected implementation(s)

  • Go: exploitable (reproduced)
  • Rust: forwards the upgrade request and relays the daemon's 101, but the connection breaks right after; no stdin reached the container
  • TypeScript: the request timed out; no stdin reached the container

Rust and TS are not exploitable in this probe, but both forward an attach request they should deny.

To Reproduce

  1. docker run -d -i --name zzws busybox sh -c 'while read l; do echo "GOT:$l" >> /tmp/in.txt; done'
  2. Run the Go proxy (--readonly or not) with --config-dir=deploy/config.
  3. Over the proxy socket, send GET /containers/zzws/attach/ws?stdin=1&stream=1 HTTP/1.1 with Upgrade: websocket, Connection: Upgrade, Sec-WebSocket-Key, Sec-WebSocket-Version: 13, then one masked text frame pwned-via-readonly-proxy.
  4. Result: HTTP/1.1 101 Switching Protocols; docker exec zzws cat /tmp/in.txt prints GOT:pwned-via-readonly-proxy. Audit log: "decision":"ALLOW" … "path":"/containers/zzws/attach/ws".

Expected behavior

  • Deny attach in the router for every method, like exec: attach as a whole segment after /containers/{name} (covering /attach and /attach/ws), with a message such as attach is not allowed. (POST /containers/{name}/attach is already default-denied as a non-lifecycle POST; the GET …/attach/ws form is the gap.)
  • Refuse protocol upgrades in all three transports: strip or reject requests carrying Upgrade/Connection: Upgrade, so no endpoint can be turned into a raw stream. Defence in depth; the Docker CLI's legitimate uses of upgrade (attach, exec start) are already denied.
  • Spec: an attach deny rule and property in spec/router.qnt mirroring execNeverAllowed; table rows in all three; an integration check that the upgrade is refused with the proxy's 403.

Alternatives considered:

  • Only block upgrades in the transport. Rejected alone: the plain (non-upgrade) POST /containers/{id}/attach hijack path should stay denied by the router too, and the router is where the spec lives.
  • Treat --readonly specially. Rejected: the gap exists in every mode.

Environment

  • Docker 29.4.0 (OrbStack); Go binary from fix/readonly-router-75 (same router/transport as main for this path).

Additional context
Consider a security advisory for the Go releases once fixed.

主要语言
Rust
星标
2
派生
0
平均合并
16 小时 14 分钟
30 天内合并 PR
25

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

ChainSafe/docker-socket-policy 的其他 Issue

查看 ChainSafe/docker-socket-policy 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。