Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Go proxy allows websocket attach (GET /containers/{name}/attach/ws), giving stdin access to containers

オープン
  • 何か問題がありますか？
#76 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
docker, go, rust, typescript
領域
api, backend, security

調査の方向性

Start with the Go router and go/internal/proxy/transport.go, then compare the Rust and TypeScript transports. Read spec/router.qnt and the existing execNeverAllowed rule; add coverage in the three router tables and an integration check for the websocket upgrade. Done means attach paths are denied across methods and the upgrade receives the proxy's 403 in all three implementations.

索引モデルが issue の本文から書いたものです。

説明

Priority: P0 Type: Bug

Describe the bug
The Go proxy lets a client write to a container's stdin through a websocket attach: GET /containers/{name}/attach/ws?stdin=1&stream=1 with Upgrade: websocket. The router treats it as a read (GET passthrough), and go/internal/proxy/transport.go (httputil.ReverseProxy) passes the protocol upgrade through, so the client gets a bidirectional stream to the container. Attaching to a container whose main process is a shell is equivalent to exec, which the proxy exists to deny. This holds with and without --readonly.

Found in the review of the #75 fix (fix/readonly-router-75); not introduced by it.

Affected implementation(s)

  • Go: exploitable (reproduced)
  • Rust: forwards the upgrade request and relays the daemon's 101, but the connection breaks right after; no stdin reached the container
  • TypeScript: the request timed out; no stdin reached the container

Rust and TS are not exploitable in this probe, but both forward an attach request they should deny.

To Reproduce

  1. docker run -d -i --name zzws busybox sh -c 'while read l; do echo "GOT:$l" >> /tmp/in.txt; done'
  2. Run the Go proxy (--readonly or not) with --config-dir=deploy/config.
  3. Over the proxy socket, send GET /containers/zzws/attach/ws?stdin=1&stream=1 HTTP/1.1 with Upgrade: websocket, Connection: Upgrade, Sec-WebSocket-Key, Sec-WebSocket-Version: 13, then one masked text frame pwned-via-readonly-proxy.
  4. Result: HTTP/1.1 101 Switching Protocols; docker exec zzws cat /tmp/in.txt prints GOT:pwned-via-readonly-proxy. Audit log: "decision":"ALLOW" … "path":"/containers/zzws/attach/ws".

Expected behavior

  • Deny attach in the router for every method, like exec: attach as a whole segment after /containers/{name} (covering /attach and /attach/ws), with a message such as attach is not allowed. (POST /containers/{name}/attach is already default-denied as a non-lifecycle POST; the GET …/attach/ws form is the gap.)
  • Refuse protocol upgrades in all three transports: strip or reject requests carrying Upgrade/Connection: Upgrade, so no endpoint can be turned into a raw stream. Defence in depth; the Docker CLI's legitimate uses of upgrade (attach, exec start) are already denied.
  • Spec: an attach deny rule and property in spec/router.qnt mirroring execNeverAllowed; table rows in all three; an integration check that the upgrade is refused with the proxy's 403.

Alternatives considered:

  • Only block upgrades in the transport. Rejected alone: the plain (non-upgrade) POST /containers/{id}/attach hijack path should stay denied by the router too, and the router is where the spec lives.
  • Treat --readonly specially. Rejected: the gap exists in every mode.

Environment

  • Docker 29.4.0 (OrbStack); Go binary from fix/readonly-router-75 (same router/transport as main for this path).

Additional context
Consider a security advisory for the Go releases once fixed.

主要言語
Rust
スター
2
フォーク
0
平均マージ
16時間 14分
マージ済み PR（30日）
25

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

ChainSafe/docker-socket-policy のほかの issue

ChainSafe/docker-socket-policy の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。