[BUG] Unhandled AttributeError on empty database queries for GeneralData and CCExtractorVersion

未关闭
#1,275 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 4 天内回复

@Aspirant200715 已经在做这个了。

开始于 2026年11月13日。

  • #1276 来自 @Aspirant200715 —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
backend

调研方向

The crashes are in the .first().value and .first().commit lookups in mod_home/controllers.py, mod_sample/controllers.py and mod_test/controllers.py. Start by reading those three query sites and the existing tests under tests/test_home, tests/test_sample and tests/test_test. Done means the three routes no longer return HTTP 500 on an unseeded database, and the test endpoint raises TestNotFoundException. The reporter says a fix is already in progress, so check with them before starting.

由索引模型根据 Issue 内容生成。

描述

Sample platform commit:

ce8539dab74eb7dbc868b89d18060da258ec3ce9

Contributor Checklist

In raising this issue, I confirm the following:

Familiarity with the Project
  • I have never visited/used the platform.
  • I have used the platform just a couple of times.
  • I have used the platform extensively, but have not contributed previously.
  • I am an active contributor to the platform.

Summary

When sample-platform is initialized on a fresh installation or against an empty database where GeneralData or CCExtractorVersion records have not yet been seeded, multiple endpoints crash with unhandled AttributeError exceptions:

  • 'NoneType' object has no attribute 'value'
  • 'NoneType' object has no attribute 'commit'

These exceptions result in HTTP 500 responses instead of graceful handling of missing database records.

Affected Routes & Files

1. Homepage (/)

File: mod_home/controllers.py

The following query directly accesses .value on the result of .first():

GeneralData.query.filter(
    GeneralData.key == 'last_commit'
).first().value

If the last_commit entry does not exist, .first() returns None, resulting in an AttributeError.

2. Sample Details (/sample/<id>)

File: mod_sample/controllers.py

Two queries are vulnerable to the same issue:

GeneralData.query.filter(
    GeneralData.key == 'last_commit'
).first().value
CCExtractorVersion.query.order_by(
    CCExtractorVersion.released.desc()
).first().commit

Both queries can return None when the database hasn't been seeded.

Additionally, passing a None commit hash to Test.query.filter(Test.commit == ...) triggers unnecessary database lookups using WHERE commit IS NULL.

3. Platform Tests (/test/by_platform/<platform>)

File: mod_test/controllers.py

The following query crashes when the platform-specific commit entry is missing:

commit_hash = GeneralData.query.filter(
    GeneralData.key == 'fetch_commit_' + platform.value
).first().value

Instead of raising the expected TestNotFoundException, the endpoint returns an unhandled HTTP 500 error.


Expected Behavior
  • The homepage (/) should load gracefully even when the last_commit database entry is missing.
  • The sample details page (/sample/<id>) should handle missing commit information without crashing or performing unnecessary database lookups.
  • The platform tests endpoint (/test/by_platform/<platform>) should raise TestNotFoundException when no commit entry exists, allowing the application to render the appropriate 404 response instead of returning HTTP 500.
Proposed Solution
  1. Add appropriate None checks around .first() query results in:

    • mod_home/controllers.py
    • mod_sample/controllers.py
    • mod_test/controllers.py
  2. Skip downstream Test.query lookups in mod_sample/controllers.py whenever the corresponding commit hashes are None.

  3. Raise TestNotFoundException in mod_test/controllers.py when no platform-specific commit entry exists.

  4. Add unit tests covering unseeded database scenarios in:

    • tests/test_home/test_controllers.py
    • tests/test_sample/test_controllers.py
    • tests/test_test/test_controllers.py

I have implemented a fix along with the corresponding unit tests and am preparing to submit a PR.

主要语言
Python
星标
31
派生
92
平均合并
4 天 9 小时
30 天内合并 PR
29

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

CCExtractor/sample-platform 的其他 Issue

查看 CCExtractor/sample-platform 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。