[BUG] Unhandled AttributeError on empty database queries for GeneralData and CCExtractorVersion
I maintainer di solito rispondono entro 4 giorni
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 35/100
Direzione di ricerca
The crashes are in the .first().value and .first().commit lookups in mod_home/controllers.py, mod_sample/controllers.py and mod_test/controllers.py. Start by reading those three query sites and the existing tests under tests/test_home, tests/test_sample and tests/test_test. Done means the three routes no longer return HTTP 500 on an unseeded database, and the test endpoint raises TestNotFoundException. The reporter says a fix is already in progress, so check with them before starting.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Sample platform commit:
ce8539dab74eb7dbc868b89d18060da258ec3ce9
Contributor Checklist
In raising this issue, I confirm the following:
- I have read and understood the [Contributors Guide](https://github.com/CCExtractor/sample-platform/blob/master/.github/CONTRIBUTING.md).
- I have checked that the bug fix I'm reporting can be replicated, or that the feature I'm suggesting isn't already present.
- I have checked that the issue I'm posting hasn't already been reported.
- I have checked that the issue hasn't already been solved and that no duplicates exist in [closed issues](https://github.com/CCExtractor/sample-platform/issues?q=is%3Aissue+is%3Aclosed) or [open issues](https://github.com/CCExtractor/sample-platform/issues).
- I have checked the Pull Requests tab for existing solutions or implementations related to this issue.
Familiarity with the Project
- I have never visited/used the platform.
- I have used the platform just a couple of times.
- I have used the platform extensively, but have not contributed previously.
- I am an active contributor to the platform.
Summary
When sample-platform is initialized on a fresh installation or against an empty database where GeneralData or CCExtractorVersion records have not yet been seeded, multiple endpoints crash with unhandled AttributeError exceptions:
'NoneType' object has no attribute 'value''NoneType' object has no attribute 'commit'
These exceptions result in HTTP 500 responses instead of graceful handling of missing database records.
Affected Routes & Files
1. Homepage (/)
File: mod_home/controllers.py
The following query directly accesses .value on the result of .first():
GeneralData.query.filter(
GeneralData.key == 'last_commit'
).first().value
If the last_commit entry does not exist, .first() returns None, resulting in an AttributeError.
2. Sample Details (/sample/<id>)
File: mod_sample/controllers.py
Two queries are vulnerable to the same issue:
GeneralData.query.filter(
GeneralData.key == 'last_commit'
).first().value
CCExtractorVersion.query.order_by(
CCExtractorVersion.released.desc()
).first().commit
Both queries can return None when the database hasn't been seeded.
Additionally, passing a None commit hash to Test.query.filter(Test.commit == ...) triggers unnecessary database lookups using WHERE commit IS NULL.
3. Platform Tests (/test/by_platform/<platform>)
File: mod_test/controllers.py
The following query crashes when the platform-specific commit entry is missing:
commit_hash = GeneralData.query.filter(
GeneralData.key == 'fetch_commit_' + platform.value
).first().value
Instead of raising the expected TestNotFoundException, the endpoint returns an unhandled HTTP 500 error.
Expected Behavior
- The homepage (
/) should load gracefully even when thelast_commitdatabase entry is missing. - The sample details page (
/sample/<id>) should handle missing commit information without crashing or performing unnecessary database lookups. - The platform tests endpoint (
/test/by_platform/<platform>) should raiseTestNotFoundExceptionwhen no commit entry exists, allowing the application to render the appropriate 404 response instead of returning HTTP 500.
Proposed Solution
-
Add appropriate
Nonechecks around.first()query results in:mod_home/controllers.pymod_sample/controllers.pymod_test/controllers.py
-
Skip downstream
Test.querylookups inmod_sample/controllers.pywhenever the corresponding commit hashes areNone. -
Raise
TestNotFoundExceptioninmod_test/controllers.pywhen no platform-specific commit entry exists. -
Add unit tests covering unseeded database scenarios in:
tests/test_home/test_controllers.pytests/test_sample/test_controllers.pytests/test_test/test_controllers.py
I have implemented a fix along with the corresponding unit tests and am preparing to submit a PR.
- Lingua principale
- Python
- Stelle
- 31
- Fork
- 92
- Merge medio
- 4g 9h
- PR unite (30g)
- 29
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di CCExtractor/sample-platform
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
CCExtractor/sample-platform#1273 · 1 commento ·
I maintainer di solito rispondono entro 4 giorni
-
[BUG] `TypeError: 'ContentFile' object is not subscriptable` in mod_upload when creating GitHub issueForse già presa @garv-sanveria l’ha presa 16 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 30/100
CCExtractor/sample-platform#1261 ·
I maintainer di solito rispondono entro 4 giorni
-
[BUG] Missing timeouts on 5 outbound HTTP calls outside mod_ci (follow-up to #943)Forse già presa @devnishantt l’ha presa 54 giorni fa. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 84/100
CCExtractor/sample-platform#1192 · 2 commenti ·
I maintainer di solito rispondono entro 4 giorni
-
[Feature Request] Improve comparison algorithm to handle frame offsets intelligently (GSoC Qualification)Forse di nuovo libera Una pull request per questa issue è stata chiusa senza essere unita. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
CCExtractor/sample-platform#1079 ·
I maintainer di solito rispondono entro 4 giorni
-
[BUG] never-worked baseline handling is not fully integrated into trusted CI reportingForse di nuovo libera Una pull request per questa issue è stata chiusa senza essere unita. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 42/100
CCExtractor/sample-platform#1057 · 2 commenti ·
I maintainer di solito rispondono entro 4 giorni
Tutte le issue di CCExtractor/sample-platform
Issue simili
-
[Bug]: DoubleMLData.from_arrays checks the treatment d with force_all_x_finite instead of force_all_d_finiteForse già presa @leninworld l’ha presa oggi. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
DoubleML/doubleml-for-py#471 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
python-pillow/Pillow#10590 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
I maintainer di solito rispondono entro 1 giorno
-
BUG: ZarrTrace fails in init_trace for models with datetime coordinates (object dtype coord array)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
I maintainer di solito rispondono entro 2 giorni