[BUG] Unhandled AttributeError on empty database queries for GeneralData and CCExtractorVersion

Aberta
#1,275 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 4 dias

@Aspirant200715 já está trabalhando nisso.

Desde 13/11/2026.

  • #1276 de @Aspirant200715 — aberto

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
python
Domínio
backend

Direção de pesquisa

The crashes are in the .first().value and .first().commit lookups in mod_home/controllers.py, mod_sample/controllers.py and mod_test/controllers.py. Start by reading those three query sites and the existing tests under tests/test_home, tests/test_sample and tests/test_test. Done means the three routes no longer return HTTP 500 on an unseeded database, and the test endpoint raises TestNotFoundException. The reporter says a fix is already in progress, so check with them before starting.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Sample platform commit:

ce8539dab74eb7dbc868b89d18060da258ec3ce9

Contributor Checklist

In raising this issue, I confirm the following:

Familiarity with the Project
  • I have never visited/used the platform.
  • I have used the platform just a couple of times.
  • I have used the platform extensively, but have not contributed previously.
  • I am an active contributor to the platform.

Summary

When sample-platform is initialized on a fresh installation or against an empty database where GeneralData or CCExtractorVersion records have not yet been seeded, multiple endpoints crash with unhandled AttributeError exceptions:

  • 'NoneType' object has no attribute 'value'
  • 'NoneType' object has no attribute 'commit'

These exceptions result in HTTP 500 responses instead of graceful handling of missing database records.

Affected Routes & Files

1. Homepage (/)

File: mod_home/controllers.py

The following query directly accesses .value on the result of .first():

GeneralData.query.filter(
    GeneralData.key == 'last_commit'
).first().value

If the last_commit entry does not exist, .first() returns None, resulting in an AttributeError.

2. Sample Details (/sample/<id>)

File: mod_sample/controllers.py

Two queries are vulnerable to the same issue:

GeneralData.query.filter(
    GeneralData.key == 'last_commit'
).first().value
CCExtractorVersion.query.order_by(
    CCExtractorVersion.released.desc()
).first().commit

Both queries can return None when the database hasn't been seeded.

Additionally, passing a None commit hash to Test.query.filter(Test.commit == ...) triggers unnecessary database lookups using WHERE commit IS NULL.

3. Platform Tests (/test/by_platform/<platform>)

File: mod_test/controllers.py

The following query crashes when the platform-specific commit entry is missing:

commit_hash = GeneralData.query.filter(
    GeneralData.key == 'fetch_commit_' + platform.value
).first().value

Instead of raising the expected TestNotFoundException, the endpoint returns an unhandled HTTP 500 error.


Expected Behavior
  • The homepage (/) should load gracefully even when the last_commit database entry is missing.
  • The sample details page (/sample/<id>) should handle missing commit information without crashing or performing unnecessary database lookups.
  • The platform tests endpoint (/test/by_platform/<platform>) should raise TestNotFoundException when no commit entry exists, allowing the application to render the appropriate 404 response instead of returning HTTP 500.
Proposed Solution
  1. Add appropriate None checks around .first() query results in:

    • mod_home/controllers.py
    • mod_sample/controllers.py
    • mod_test/controllers.py
  2. Skip downstream Test.query lookups in mod_sample/controllers.py whenever the corresponding commit hashes are None.

  3. Raise TestNotFoundException in mod_test/controllers.py when no platform-specific commit entry exists.

  4. Add unit tests covering unseeded database scenarios in:

    • tests/test_home/test_controllers.py
    • tests/test_sample/test_controllers.py
    • tests/test_test/test_controllers.py

I have implemented a fix along with the corresponding unit tests and am preparing to submit a PR.

Linguagem predominante
Python
Estrelas
31
Forks
92
Merge médio
4d 9h
PRs com merge (30d)
29

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de CCExtractor/sample-platform

Todas as issues de CCExtractor/sample-platform

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.