prompt wraps poorly on macOS

未关闭
#16 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
r
领域
cli

调研方向

Start at R/utilities.R around line 79 and inspect other uses of .util_ask(), as the issue suggests they may need the same treatment. Reproduce the cache-creation prompt on macOS and verify that the full message and “(yes/no):” remain in the intended order without left-aligned wrapping.

由索引模型根据 Issue 内容生成。

描述

When prompted to create a new AnnotationHub cache, at https://github.com/Bioconductor/BiocFileCache/blob/master/R/utilities.R#L79 , I see the equivalent of

> txt = paste0(cache, "\n  does not exist, create directory?", " (yes/no): ")
> readline(txt)
/Users/ma38727/Library/Caches/BiocFileCache
(yes/no):  exist, create directory?

where '(yes/no):' has been aligned to the left; maybe readline() is trying to wrap line width?

> sessionInfo()
R version 3.6.0 alpha (2019-03-29 r76306)
Platform: x86_64-apple-darwin17.7.0 (64-bit)
Running under: macOS High Sierra 10.13.6

Matrix products: default
BLAS:   /Users/ma38727/bin/R-3-6-branch/lib/libRblas.dylib
LAPACK: /Users/ma38727/bin/R-3-6-branch/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] BiocFileCache_1.7.3 dbplyr_1.3.0

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.1       digest_0.6.18    crayon_1.3.4     dplyr_0.8.0.1
 [5] assertthat_0.2.1 rappdirs_0.3.1   R6_2.4.0         DBI_1.0.0
 [9] magrittr_1.5     RSQLite_2.1.1    httr_1.4.0       pillar_1.3.1
[13] rlang_0.3.3      curl_3.3         blob_1.1.1       bit64_0.9-7
[17] glue_1.3.1       bit_1.1-14       purrr_0.3.2      compiler_3.6.0
[21] pkgconfig_2.0.2  memoise_1.1.0    tidyselect_0.2.5 tibble_2.1.1

A solution might remove the \n and instead provide a single line, like

txt = paste0("'", cache, "' does not exist, create directory?", " (yes/no): ")

likely other uses of .util_ask() would need similar modification.

... or use cat() (stdout) for the body of the text, and readline() for "yes/no: "

主要语言
R
星标
14
派生
9
PR 合并指标
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Bioconductor/BiocFileCache 的其他 Issue

查看 Bioconductor/BiocFileCache 的全部 Issue

相似的 Issue

更多 R Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。