prompt wraps poorly on macOS

未關閉
#16 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
45/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
r
領域
cli

研究方向

Start at R/utilities.R around line 79 and inspect other uses of .util_ask(), as the issue suggests they may need the same treatment. Reproduce the cache-creation prompt on macOS and verify that the full message and “(yes/no):” remain in the intended order without left-aligned wrapping.

由索引模型根據 Issue 內容生成。

描述

When prompted to create a new AnnotationHub cache, at https://github.com/Bioconductor/BiocFileCache/blob/master/R/utilities.R#L79 , I see the equivalent of

> txt = paste0(cache, "\n  does not exist, create directory?", " (yes/no): ")
> readline(txt)
/Users/ma38727/Library/Caches/BiocFileCache
(yes/no):  exist, create directory?

where '(yes/no):' has been aligned to the left; maybe readline() is trying to wrap line width?

> sessionInfo()
R version 3.6.0 alpha (2019-03-29 r76306)
Platform: x86_64-apple-darwin17.7.0 (64-bit)
Running under: macOS High Sierra 10.13.6

Matrix products: default
BLAS:   /Users/ma38727/bin/R-3-6-branch/lib/libRblas.dylib
LAPACK: /Users/ma38727/bin/R-3-6-branch/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] BiocFileCache_1.7.3 dbplyr_1.3.0

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.1       digest_0.6.18    crayon_1.3.4     dplyr_0.8.0.1
 [5] assertthat_0.2.1 rappdirs_0.3.1   R6_2.4.0         DBI_1.0.0
 [9] magrittr_1.5     RSQLite_2.1.1    httr_1.4.0       pillar_1.3.1
[13] rlang_0.3.3      curl_3.3         blob_1.1.1       bit64_0.9-7
[17] glue_1.3.1       bit_1.1-14       purrr_0.3.2      compiler_3.6.0
[21] pkgconfig_2.0.2  memoise_1.1.0    tidyselect_0.2.5 tibble_2.1.1

A solution might remove the \n and instead provide a single line, like

txt = paste0("'", cache, "' does not exist, create directory?", " (yes/no): ")

likely other uses of .util_ask() would need similar modification.

... or use cat() (stdout) for the body of the text, and readline() for "yes/no: "

主要語言
R
星號
14
分支
9
PR 合併指標
30 天內沒有已合併 PR

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

Bioconductor/BiocFileCache 的其他 Issue

查看 Bioconductor/BiocFileCache 的全部 Issue

相似的 Issue

更多 R Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。