bfcneedsupdate() compares 'expires' by date, so short max-age resources are stale immediately after download
还没有人认领这个 Issue。
评估
调研方向
Start in R/BiocFileCache-class.R at the bfcneedsupdate() expiry check near line 1024, then inspect its tests for expiry and ETag/Last-Modified behavior. Reproduce with a resource whose max-age is shorter than the time until midnight; the fix is done when it is not marked stale immediately after download and the existing freshness checks still behave correctly.
由索引模型根据 Issue 内容生成。
描述
Problem
bfcneedsupdate() checks expiry by calendar date:
https://github.com/Bioconductor/BiocFileCache/blob/devel/R/BiocFileCache-class.R#L1024
expired <- as.Date(file_expires, optional=TRUE) <= Sys.Date()
expires is set to response time + max-age (since #55). When max-age is shorter than the time left until midnight, the expiry date is today. The check is then TRUE immediately, and because expired short-circuits the ETag/Last-Modified comparison, the resource reports as stale right after download.
bioconductor.org now serves files through Cloudflare with short max-age values, so this affects most Bioconductor-hosted resources:
| URL | cache-control |
|---|---|
packages/stats/bioc/bioc_pkg_stats.tab |
max-age=300, s-maxage=3600 |
checkResults/devel/bioc-LATEST/BUILD_STATUS_DB.txt |
max-age=300, s-maxage=31536000 |
packages/3.23/bioc/VIEWS |
max-age=30, s-maxage=31536000 |
Reprex
BiocFileCache 3.2.0 (release); the same line is in devel 3.3.3.
library(BiocFileCache)
url <- "https://bioconductor.org/packages/stats/bioc/bioc_pkg_stats.tab"
bfc <- BiocFileCache(tempfile(), ask = FALSE)
bfcadd(bfc, rname = url, fpath = url, rtype = "web", action = "copy", download = TRUE)
rid <- bfcquery(bfc, url, "rname", exact = TRUE)$rid
bfcinfo(bfc, rid)$expires # a few minutes from now, i.e. today
bfcneedsupdate(bfc, rid) # TRUE, seconds after the download
Impact
Any package that does if (bfcneedsupdate(...)) bfcdownload(...) on these URLs re-downloads them on every call, so the cache does nothing. BiocPkgTools hit this as a test failure on r-universe (seandavi/BiocPkgTools#92) and worked around it in seandavi/BiocPkgTools#93 by doing its own size/ETag/Last-Modified check.
Suggested fix
Compare full timestamps instead of dates, e.g.
expired <- as.POSIXct(file_expires, tz = "GMT", optional = TRUE) <= Sys.time()
It would also be worth considering whether an expired entry should fall through to the ETag / Last-Modified check rather than returning TRUE outright. With max-age=30, a cache that has merely passed max-age is usually still current, and a matching ETag is stronger evidence than expiry.
- 主要语言
- R
- 星标
- 14
- 派生
- 9
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Bioconductor/BiocFileCache 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
Bioconductor/BiocFileCache#76 · 1 条评论 ·
-
难度 5/5 一周以上 新手友好度 35/100
Bioconductor/BiocFileCache#72 · 3 条评论 ·
-
难度 3/5 1-2 天 新手友好度 25/100
Bioconductor/BiocFileCache#66 · 16 条评论 ·
-
难度 3/5 1-2 天 新手友好度 35/100
Bioconductor/BiocFileCache#60 · 3 条评论 ·
-
难度 4/5 3-5 天 新手友好度 30/100
查看 Bioconductor/BiocFileCache 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
HelenaLC/spatialdataR#295 ·
-
size-time-budget
难度 2/5 1-3 小时 新手友好度 69/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
Openscapes/blogscapes#61 ·
维护者通常 1 天内回复
-
bug posit-ai
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100