fetch/XHR transport failures and unhandled rejections lose all diagnostic fidelity before reaching the embedding app
维护者通常 1 天内回复
评估
这个 Issue 还没有评估数据。
描述
Applications embedding Babylon Native depend on field crash reports for ongoing maintenance, and today a fetch()/XMLHttpRequest failure arrives there with no usable signal: DNS failure, connection refused, TLS rejection, proxy auth failure, server outage, and a missing bundled app:/// asset are all byte-identical, and an un-caught rejection never reaches the host (BN) application at all. This issue tracks the chain of fixes; each hop is independently shippable.
The chain (where fidelity is lost today)
-
UrlLib swallows transport errors at the source.✅ Fixed by BabylonJS/UrlLib#31 (open): the Apple backend discarded theNSError(long-standing in-code TODO) and the curl backend caught and dropped its own failure, leaving onlyStatusCode() == 0. UrlLib now exposesErrorString()/ErrorSymbol()/ErrorCode(), normalized as"<domain>:<symbol>(<code>): <detail>"(e.g.curl:CURLE_COULDNT_RESOLVE_HOST(6): ...,nsurl:NSURLErrorCannotConnectToHost(-1004): ...,urllib:AppResourceNotFound(0): ...) — stable tokens for observability-pipeline filtering, purely additive (status-0 contract unchanged). -
The fetch polyfill flattens every transport failure to a constant string.
Fetch.cppthrowsstd::runtime_error{"fetch: network request failed"}, discardingresult.error()and the URL/method context it has in scope; the rejection surfaces as a plainError(browsers/Node/Bun:TypeError) with nocause, nocode, and a.stacksnapshotted inside the scheduler tick — i.e. zero user frames. Proposed shape, once the UrlLib pin includes #31:- reject with a
TypeErrorwhose message is stable ("fetch failed"style — keeps crash-report grouping intact), carrying the variable detail as properties:cause(message fromErrorString()),code(ErrorSymbol()),url; - capture the JS call-site stack synchronously inside
fetch()beforeSendAsync()(create the rejection Error, or a stack carrier, while user frames are still on the stack — the undici approach) so crash reports can attribute the failing call; - same treatment for
XMLHttpRequest's error path.
- reject with a
-
Unhandled promise rejections never reach
UnhandledExceptionHandler.AppRuntime::Dispatchonly catches synchronousNapi::Errorthrows from dispatched callbacks; no engine-level rejection tracker is wired anywhere in Core, so a fire-and-forgetfetch()failure (or a throw inside any.then) vanishes silently — the embedder's handler never fires and the process exits 0. Proposal: an opt-inAppRuntime::Optionshandler (or routing into the existing one) fed per engine —Isolate::SetPromiseRejectCallback(V8),JsSetHostPromiseRejectionTracker(Chakra),JSGlobalContextSetUnhandledRejectionCallback(JavaScriptCore), and the JSI tracker — the per-engine seams already exist asAppRuntime_{V8,Chakra,JavaScriptCore,JSI}.cpp. -
fetchignoresinit.signal. The implementation passesarcana::cancellation::none()for both continuations, so abort never rejects (AbortError) and never cancels the transport. Two prerequisites:UrlRequest::Abort()currently only cancels the Windows backend (the curl/NSURLSession backends never observem_cancellationSource), and theAbortSignalpolyfill predates the modern spec (noreason/throwIfAborted(), writableaborted). Worth sequencing with BabylonJS/BabylonNative#1708, which installsAbortControllerglobally in the Playground — after which library feature-detection passes while signals silently no-op, and user-initiated cancellations become indistinguishable from network failures in telemetry.
Validation
Beyond unit tests per hop (UrlLib#31 already ships offline-deterministic transport-failure tests + CI), the highest-value conformance ports for this area: the WPT fetch/api/abort/general.any.js core cases (pre-aborted/mid-flight/post-settle, signal.reason), undici's fetch failed-with-cause assertions from test/fetch/client-fetch.js, a four-way failure-shape bank (refused / NXDOMAIN / bad TLS / missing local asset must be distinguishable and TypeError-shaped), and a native-side test that an unhandled rejection actually reaches the host handler.
Happy to submit PRs for hops 2–4 individually (2 is unblocked as soon as the UrlLib pin can include #31; 3 and 4 are independent).
Related: #188 (fetch polyfill), #195 (statusText — same UrlLib-consumption pattern hop 2 would follow), BabylonJS/BabylonNative#1707.
- 主要语言
- C++
- 星标
- 22
- 派生
- 23
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 3
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
BabylonJS/JsRuntimeHost 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
BabylonJS/JsRuntimeHost#234 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
BabylonJS/JsRuntimeHost#173 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 42/100
BabylonJS/JsRuntimeHost#241 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
BabylonJS/JsRuntimeHost#228 ·
维护者通常 1 天内回复
-
napi_unwrap does not reject objects that were never wrapped (V8 port faults, QuickJS port confuses types)可能已有人在做 @bghgary 于 46 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 68/100
BabylonJS/JsRuntimeHost#226 ·
维护者通常 1 天内回复
查看 BabylonJS/JsRuntimeHost 的全部 Issue
相似的 Issue
-
area:runtime good first issue
难度 2/5 1-3 小时 新手友好度 72/100
WATonomous/wato_f1tenth#39 ·
-
[APP BUG]: Sorting by name after searching can bring up irrelevant results可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
shadps4-emu/shadps4-qtlauncher#465 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
duckdb/duckdb-excel#104 ·
-
难度 2/5 1-3 小时 新手友好度 85/100
lxqt/lxqt-powermanagement#495 ·
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
Qiskit/qiskit-aer#2466 ·