A CLI installed with go install reports version dev: mismatch warning on every connect, and probe_version pins are refused

未关闭
#888 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
go
领域
backend, cli

调研方向

Start by reading internal/cli version handling and the release workflow or Makefile flags that set Version; then inspect the version checks in internal/probelink and how probe_version is enforced. The issue describes several possible fixes but does not choose one, so first establish the intended behavior for binaries installed with go install. Done means that behavior is covered for version warnings, compatibility checks, and pinned versions.

由索引模型根据 Issue 内容生成。

描述

What happens

A CLI installed with go install github.com/alphawavesystems/flutter-probe/cmd/[email protected] reports its version as dev:

$ probe version
probe version dev

internal/cli.Version is "dev" unless the linker sets it. The release workflow and the Makefile do (-X .../internal/cli.Version=...); go install does not. The binary does carry the module version in its build information (go version -m shows mod github.com/alphawavesystems/flutter-probe v0.27.0), and nothing in internal/cli, internal/probelink or cmd reads it (debug.ReadBuildInfo is not used).

What the version string is used for

Measured by calling the functions with dev:

  • Agent version warning. probelink.VersionMismatchWarning("dev", "0.26.1") returns version mismatch: CLI vdev <-> agent v0.26.1 — this combination is untested ..., so a go install CLI prints that warning on every connect. The doc comment of the function says an unknown or unparsable version produces no warning, but the code only skips an empty string; dev is compared as text.
  • Major check. MajorVersionIncompatible("dev", "0.26.1") is false: dev does not parse, so it never blocks the connection (as its comment says).
  • probe_version in probe.yaml. A project that pins probe_version: 0.27.0 is not satisfied by dev (ParseProbeVersion("0.27.0") then Satisfied("dev") is false), so probe test stops with "the installed CLI is dev, but probe.yaml requires probe_version 0.27.0. No test was run." A go-installed CLI cannot run a project that pins the version, even when it is that release.

Not changed

No fix proposed here. Options for the owner of the CLI: read the module version from debug.ReadBuildInfo when Version is dev; treat dev as unknown in VersionMismatchWarning (matching its comment); or document that go install builds report dev. The installation page's Option C (go install) is the place where users meet it.

主要语言
Go
星标
6
派生
3
平均合并
6 小时 28 分钟
30 天内合并 PR
362

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

AlphaWaveSystems/flutter-probe 的其他 Issue

查看 AlphaWaveSystems/flutter-probe 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。