A CLI installed with go install reports version dev: mismatch warning on every connect, and probe_version pins are refused

オープン
#888 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
45/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
go
領域
backend, cli

調査の方向性

Start by reading internal/cli version handling and the release workflow or Makefile flags that set Version; then inspect the version checks in internal/probelink and how probe_version is enforced. The issue describes several possible fixes but does not choose one, so first establish the intended behavior for binaries installed with go install. Done means that behavior is covered for version warnings, compatibility checks, and pinned versions.

索引モデルが issue の本文から書いたものです。

説明

What happens

A CLI installed with go install github.com/alphawavesystems/flutter-probe/cmd/[email protected] reports its version as dev:

$ probe version
probe version dev

internal/cli.Version is "dev" unless the linker sets it. The release workflow and the Makefile do (-X .../internal/cli.Version=...); go install does not. The binary does carry the module version in its build information (go version -m shows mod github.com/alphawavesystems/flutter-probe v0.27.0), and nothing in internal/cli, internal/probelink or cmd reads it (debug.ReadBuildInfo is not used).

What the version string is used for

Measured by calling the functions with dev:

  • Agent version warning. probelink.VersionMismatchWarning("dev", "0.26.1") returns version mismatch: CLI vdev <-> agent v0.26.1 — this combination is untested ..., so a go install CLI prints that warning on every connect. The doc comment of the function says an unknown or unparsable version produces no warning, but the code only skips an empty string; dev is compared as text.
  • Major check. MajorVersionIncompatible("dev", "0.26.1") is false: dev does not parse, so it never blocks the connection (as its comment says).
  • probe_version in probe.yaml. A project that pins probe_version: 0.27.0 is not satisfied by dev (ParseProbeVersion("0.27.0") then Satisfied("dev") is false), so probe test stops with "the installed CLI is dev, but probe.yaml requires probe_version 0.27.0. No test was run." A go-installed CLI cannot run a project that pins the version, even when it is that release.

Not changed

No fix proposed here. Options for the owner of the CLI: read the module version from debug.ReadBuildInfo when Version is dev; treat dev as unknown in VersionMismatchWarning (matching its comment); or document that go install builds report dev. The installation page's Option C (go install) is the place where users meet it.

主要言語
Go
スター
6
フォーク
3
平均マージ
6時間 28分
マージ済み PR(30日)
362

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

AlphaWaveSystems/flutter-probe のほかの issue

AlphaWaveSystems/flutter-probe の issue をすべて見る

似ている issue

Go の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。