A CLI installed with go install reports version dev: mismatch warning on every connect, and probe_version pins are refused

Abierto
#888 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go
Área
backend, cli

Línea de trabajo

Start by reading internal/cli version handling and the release workflow or Makefile flags that set Version; then inspect the version checks in internal/probelink and how probe_version is enforced. The issue describes several possible fixes but does not choose one, so first establish the intended behavior for binaries installed with go install. Done means that behavior is covered for version warnings, compatibility checks, and pinned versions.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

A CLI installed with go install github.com/alphawavesystems/flutter-probe/cmd/[email protected] reports its version as dev:

$ probe version
probe version dev

internal/cli.Version is "dev" unless the linker sets it. The release workflow and the Makefile do (-X .../internal/cli.Version=...); go install does not. The binary does carry the module version in its build information (go version -m shows mod github.com/alphawavesystems/flutter-probe v0.27.0), and nothing in internal/cli, internal/probelink or cmd reads it (debug.ReadBuildInfo is not used).

What the version string is used for

Measured by calling the functions with dev:

  • Agent version warning. probelink.VersionMismatchWarning("dev", "0.26.1") returns version mismatch: CLI vdev <-> agent v0.26.1 — this combination is untested ..., so a go install CLI prints that warning on every connect. The doc comment of the function says an unknown or unparsable version produces no warning, but the code only skips an empty string; dev is compared as text.
  • Major check. MajorVersionIncompatible("dev", "0.26.1") is false: dev does not parse, so it never blocks the connection (as its comment says).
  • probe_version in probe.yaml. A project that pins probe_version: 0.27.0 is not satisfied by dev (ParseProbeVersion("0.27.0") then Satisfied("dev") is false), so probe test stops with "the installed CLI is dev, but probe.yaml requires probe_version 0.27.0. No test was run." A go-installed CLI cannot run a project that pins the version, even when it is that release.

Not changed

No fix proposed here. Options for the owner of the CLI: read the module version from debug.ReadBuildInfo when Version is dev; treat dev as unknown in VersionMismatchWarning (matching its comment); or document that go install builds report dev. The installation page's Option C (go install) is the place where users meet it.

Lenguaje dominante
Go
Estrellas
6
Forks
3
Merge medio
6 h 28 min
PR fusionados (30 d)
362

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de AlphaWaveSystems/flutter-probe

Todos los issues de AlphaWaveSystems/flutter-probe

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.