agent: is enabled passes on a disabled Radio, CupertinoButton, Slider or DropdownButton (controls the agent cannot read)

未关闭
#864 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
dart, flutter
领域
mobile, testing

调研方向

Start with _controlDisabled in probe_agent/lib/src/executor.dart and compare its supported controls with the disabled Radio, CupertinoButton, Slider and DropdownButton cases in the issue. Read the linked plan in #857 and the related discussion in #861 to understand the measured Semantics approach and its limitation for CupertinoButton. Done means disabled-state checks no longer silently pass for controls the agent cannot read.

由索引模型根据 Issue 内容生成。

描述

bug

Symptom

see #id is enabled passes on a disabled control the agent cannot read, in every position: the control as the target itself, a wrapper around it, or a text inside it. don't see #id is disabled passes too. That's a silent false pass with the current agent on plain Flutter apps.

Reported in the review of #861. The reader (_controlDisabled in probe_agent/lib/src/executor.dart) knows only ButtonStyleButton (the elevated, filled, outlined and text buttons), IconButton, FloatingActionButton, TextField, Switch and Checkbox. Every other control falls back to "not disabled", including:

  • a disabled Radio;
  • a CupertinoButton(onPressed: null);
  • a Slider(onChanged: null);
  • a DropdownButton(onChanged: null);
  • chips, SegmentedButton, PopupMenuButton, CupertinoSlider and others.

Related: with #861, a wrapper holding a disabled button and an enabled Slider reads as disabled (the slider is ignored). A wrapper holding an enabled button and a disabled Slider reads as enabled, which is wrong for the slider.

Fix

The library-neutral plan in #857 (reading enabled from the Semantics each control builds) covers these controls. It was measured for the buttons, text fields, switches, checkboxes, radios and chips, on the framework and on material_ui. CupertinoButton builds no enabled value, so the plan refuses rather than guesses there. Until then, a smaller step could refuse is enabled/is disabled on a known unread control.

主要语言
Go
星标
6
派生
3
平均合并
6 小时 28 分钟
30 天内合并 PR
362

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

AlphaWaveSystems/flutter-probe 的其他 Issue

查看 AlphaWaveSystems/flutter-probe 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。