agent: is enabled passes on a disabled Radio, CupertinoButton, Slider or DropdownButton (controls the agent cannot read)

Aperta
#864 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
dart, flutter
Ambito
mobile, testing

Direzione di ricerca

Start with _controlDisabled in probe_agent/lib/src/executor.dart and compare its supported controls with the disabled Radio, CupertinoButton, Slider and DropdownButton cases in the issue. Read the linked plan in #857 and the related discussion in #861 to understand the measured Semantics approach and its limitation for CupertinoButton. Done means disabled-state checks no longer silently pass for controls the agent cannot read.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Symptom

see #id is enabled passes on a disabled control the agent cannot read, in every position: the control as the target itself, a wrapper around it, or a text inside it. don't see #id is disabled passes too. That's a silent false pass with the current agent on plain Flutter apps.

Reported in the review of #861. The reader (_controlDisabled in probe_agent/lib/src/executor.dart) knows only ButtonStyleButton (the elevated, filled, outlined and text buttons), IconButton, FloatingActionButton, TextField, Switch and Checkbox. Every other control falls back to "not disabled", including:

  • a disabled Radio;
  • a CupertinoButton(onPressed: null);
  • a Slider(onChanged: null);
  • a DropdownButton(onChanged: null);
  • chips, SegmentedButton, PopupMenuButton, CupertinoSlider and others.

Related: with #861, a wrapper holding a disabled button and an enabled Slider reads as disabled (the slider is ignored). A wrapper holding an enabled button and a disabled Slider reads as enabled, which is wrong for the slider.

Fix

The library-neutral plan in #857 (reading enabled from the Semantics each control builds) covers these controls. It was measured for the buttons, text fields, switches, checkboxes, radios and chips, on the framework and on material_ui. CupertinoButton builds no enabled value, so the plan refuses rather than guesses there. Until then, a smaller step could refuse is enabled/is disabled on a known unread control.

Lingua principale
Go
Stelle
6
Fork
3
Merge medio
6h 28m
PR unite (30g)
362

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di AlphaWaveSystems/flutter-probe

Tutte le issue di AlphaWaveSystems/flutter-probe

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.