A node type cannot be defined outside the kernel assembly: five of Entity's abstract members are internal
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- csharp
调研方向
首先阅读 Core/Entity/Entity.Definition.cs、Functions/TreeAnalyzer/Sort.Definition.cs、Functions/Evaluation/Evaluation.Definition.cs、Functions/Output/ToSympy.Definition.cs 和 Functions/Continuous/Solvers/InvertNode.Definition.cs 中命名的五个成员定义,以及 Docs/Contributing/Packaging.md 和 Docs/Contributing/Trimming.md。运行 EveryNodeSurvivesEveryPipelineTest 并检查 trimming/AOT gate。完成的标准是:有一份文档化的 contract、一个位于独立 assembly 中的 pipeline test,并保留 reflection 和 AOT 检查。
由索引模型根据 Issue 内容生成。
描述
What is wrong
Entity is public abstract partial record, and its constructor is protected, which reads as an
invitation to derive from it. But a subclass in another assembly does not compile. Five of its
abstract members are internal or private protected, so an external type can never satisfy them:
| member | accessibility | where |
|---|---|---|
Priority |
internal abstract |
Core/Entity/Entity.Definition.cs:378 |
SortHashName(SortLevel) |
private protected abstract |
Functions/TreeAnalyzer/Sort.Definition.cs:19 |
IntrinsicCondition |
private protected abstract |
Functions/Evaluation/Evaluation.Definition.cs:72 |
ToSymPy() |
internal abstract |
Functions/Output/ToSympy.Definition.cs:13 |
InvertNode(Entity, Entity) |
private protected abstract |
Functions/Continuous/Solvers/InvertNode.Definition.cs:30 |
Deriving from Entity in a separate assembly fails with CS0534, naming each of those five among
the members it cannot implement. This is not a policy that could be relaxed by an
InternalsVisibleTo: a published extension package cannot be on that list.
Why it matters, and what is behind it
This is the concrete blocker under several roadmap items, and it is not the one they name.
#746 item 56 says the extensibility seam
is #338 — looking a type up so it can be
parsed from a string. That is the second half. The first half is being able to write the type at
all, and today you cannot. The same wall sits under item 53 (groups, rings and fields as
first-class, #440) and under the whole
tier-9 domain-package idea, which assumes a geometry or statistics pack can contribute node types.
It also means one thing the packaging decision cannot decide. Docs/Contributing/Packaging.md
(#746 item 78) works out which capabilities belong in the kernel and which ship separately, and its
answer for domain packages is blocked, not decided — because a package boundary is not what is
in the way here. Moving the LaTeX printer or the SymPy exporter out of the kernel runs into the same
five members from the other side: they are abstract members of Entity, so moving them means either
this contract becoming extensible or a visitor over all 68 node types.
Scope
This is a design decision before it is an implementation, and it should be argued before it is
built. The shape of the question:
- Which of the five are genuinely part of a node's public contract, and which are engine internals
that a visitor or a registry should own instead?ToSymPyandSortHashNamelook like the second
kind;PriorityandIntrinsicConditionlook like the first. - If a member becomes
publicorprotected, it becomes a compatibility surface — every future
change toSortLevel,Priorityor theInvertNodesignature is then breaking. That is the real
cost and it should be stated before the change, not discovered after. - Is the answer instead a sealed node hierarchy plus an explicit extension point — a node kind
that carries a name and an operation table — so that a domain package contributes data rather than
a subclass? That keepsEntityclosed, which is what makes exhaustive matching and the
EveryNodeSurvivesEveryPipelineTestreflection sweep work today. - Whatever is chosen must be trimming- and NativeAOT-safe: explicit registration, no runtime assembly
scanning. See #363,
#552 and
Docs/Contributing/Trimming.md.
Acceptance criteria
- A written decision in
Docs/Contributing/, saying what a node type outside the kernel may and may
not do, and which of the five members are part of the contract. - A test that compiles a node type from a separate assembly and puts it through the pipeline —
parse is not required, butToString,Latexize,InnerSimplified, substitution and structural
equality are. A test that only asserts the type exists proves nothing; this has to build. EveryNodeSurvivesEveryPipelineTeststill passes, and it is stated whether an external node is
in scope for it.- No new reflection on a hot path, and the trimming/AOT gate stays green.
Dependencies
Independent of everything currently open. It does not depend on
#338 — it is what #338 needs, not the
reverse. It is a prerequisite for #746 items 53 and 56 and for tier 9.
Found while measuring package boundaries for #746 item 78.
- 主要语言
- C#
- 星标
- 831
- 派生
- 79
- 平均合并
- 2 小时 22 分钟
- 30 天内合并 PR
- 507
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ASC-Community/AngouriMath 的其他 Issue
-
难度 5/5 一周以上 新手友好度 30/100
ASC-Community/AngouriMath#1807 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
ASC-Community/AngouriMath#1692 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 30/100
ASC-Community/AngouriMath#1690 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
ASC-Community/AngouriMath#1689 · 5 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
ASC-Community/AngouriMath#1684 ·
维护者通常 1 天内回复
查看 ASC-Community/AngouriMath 的全部 Issue
相似的 Issue
-
Bug pulumi/pulumi
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
activescott/lessmsi#306 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
HTML sitemap lists unpublished pages可能已有人在做 @KrzysztofPajak 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
grandnode/grandnode2#883 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复