Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Make grad() an in-planner rewrite (via FFI) so it works inside any query — recursive CTEs, DML

未關閉
#197 1 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

  • #205 來自 @JHON12091986 —— 已關閉,未合併

評估

難度
5/5
預估耗時
一週以上
新手友好度
25/100
Issue 類型
功能
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
python, rust, sql

研究方向

Start by reading the autograd implementation and the DataFusion FFI UDF code in datafusion-ffi 52, especially datafusion/ffi/src/udf/mod.rs. The preferred direction is to forward ScalarUDFImpl::simplify across the FFI boundary, including a way to pass argument Expr values. Done means grad() can be rewritten inside recursive CTEs, DML, and scalar subqueries without the plan-level Substrait round trip.

由索引模型根據 Issue 內容生成。

描述

Context

The autograd grad() surface (#192) is applied by round-tripping the whole logical plan through Substrait: XarrayContext.sql() plans the query, produces a Substrait plan, the native extension (grad_rewrite) consumes it, rewrites every grad(...) into the differentiated expression, and re-produces Substrait for Python to execute.

This works for ordinary SELECT / aggregate / join plans, but Substrait can't represent every plan shape, so grad() can't appear inside:

  • Recursive CTEs — to_substrait_plan rejects RecursiveQuery (NotImplemented("Unsupported plan type: RecursiveQuery ...")). This is what blocks a fully-declarative training loop with grad inside the recursion.
  • DML — INSERT ... SELECT grad(...) doesn't convert (DML plans aren't produced to Substrait).
  • Scalar subqueries also don't convert (Cannot convert <subquery> to Substrait).

In the gradient-descent demo (#195) we worked around this with differentiate_sql (differentiate once to SQL text, then iterate it in a recursive CTE that contains no grad marker). That's a good pattern, but the original goal — grad() directly inside the query, including recursive/DML — needs an upstream change.

Root cause

The native engine is a separate cdylib that statically links its own copy of DataFusion, so it can't share Expr/LogicalPlan objects with datafusion-python — hence the Substrait serialization bridge. Substrait is then the limiting factor: any plan shape Substrait can't carry, grad() can't be rewritten in.

The fix is to stop round-tripping plans and instead run the rewrite in-planner, as a native DataFusion rewrite that fires for any query shape. That requires one of the following upstream capabilities.

Upstream changes that would enable it

Option 1 (preferred): datafusion-ffi — forward ScalarUDFImpl::simplify for foreign UDFs

If a foreign (FFI-registered) scalar UDF could implement simplify, grad/jvp/vjp would be self-rewriting UDFs: their simplify() differentiates the argument Expr during the SimplifyExpressions pass, which runs for every query shape (recursive CTEs, DML, subqueries) with no Substrait involved.

  • Today FFI_ScalarUDF / ForeignScalarUDF only forward name, signature, return_type/return_field_from_args, coerce_types, invoke_with_args (see datafusion/ffi/src/udf/mod.rs in datafusion-ffi 52) — not simplify, so the default (identity) is used.
  • Fix: add simplify to the FFI_ScalarUDF vtable (an extern "C" entry) and call it from ForeignScalarUDF::simplify. The hard part is passing the argument Exprs across the C ABI — needs an FFI representation of Expr (e.g. reuse datafusion-proto's Expr (de)serialization, or Substrait ExtendedExpression, for just the UDF's args). This is the smallest, most surgical change and unblocks all query shapes at once. It would also let us delete the whole plan-level Substrait bridge.
Option 2: datafusion-python + datafusion-ffi — register a foreign AnalyzerRule / FunctionRewrite over FFI

Expose registering a foreign analyzer/optimizer rule on the SessionContext (e.g. SessionContext.register_analyzer_rule(<capsule>)), backed by a new FFI_AnalyzerRule in datafusion-ffi. Then grad is an analyzer rule that rewrites grad(...) during analysis for any plan. Broader than Option 1 (general extension point) but more API surface.

Option 3 (narrower / long path): Substrait support for recursion + DML

Keep the current bridge but teach it the missing plan shapes:

  • DML: Substrait has a WriteRel; datafusion-substrait would need producer/consumer support for it so INSERT ... SELECT grad(...) round-trips.
  • Recursion: Substrait the spec has no recursive-relation construct, so this is an upstream substrait-io spec gap, not just a datafusion-substrait change — the longest path.

Recommendation

Pursue Option 1 (FFI simplify forwarding). It's the smallest upstream change, removes the Substrait round-trip and its codec complexity entirely, and makes grad() work inside recursive CTEs, DML, and subqueries — i.e. the fully-declarative training loop with grad in the query. Until then, differentiate_sql + a recursive CTE (see #195) is the supported way to express an in-SQL training loop.

Filed as a follow-up to the autograd feature (#192) and its demos (#195); related to the mutable-state discussion in #194.

主要語言
Python
星號
142
分支
19
平均合併
1 天 9 小時
30 天內合併 PR
9

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

xqlsystems/xarray-sql 的其他 Issue

查看 xqlsystems/xarray-sql 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。