bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalid

未關閉
  • 哪裡不對？
#5,058 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

  • #5059 來自 @shafiktanbir —— 已關閉，未合併
  • #5070 來自 @MilindChatrabhuji —— 已關閉，未合併
  • #5086 來自 @ghazy2001 —— 已關閉，未合併

評估

難度
3/5
預估耗時
1-2 天
新手友好度
39/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
nextjs, typescript
領域
backend, frontend

研究方向

Start in apps/webapp/app/v3/featureFlags.server.ts at mergeOrgFeatureFlags and inspect how stored organization flags are parsed; the reproduction shows a valid override being lost when another stored value is invalid. Then review FeatureFlagsDialog.tsx for unsetFlag and the derived grace-stamp rows. Done means valid overrides survive invalid stored values, unsetting clears related derived values, and derived rows stay read-only when unlocked; an open linked pull request indicates this work may already be underway.

由索引模型根據 Issue 內容生成。

描述

Provide environment information

System:
OS: Linux 6.8 Ubuntu
Binaries:
Node: 22.14.0
pnpm: 9.15.0

Describe the bug

In a7f0f90e ("show stored org values for locked flags in the admin flags dialog"), the v1 and v2 admin org feature-flag routes were updated to read stored flags key-by-key via parseStoredOrgFlags(organization.featureFlags).valid, and saves now intentionally keep untouched invalid values and unknown keys from newer releases in Organization.featureFlags.

However, mergeOrgFeatureFlags in apps/webapp/app/v3/featureFlags.server.ts (used by resolveOrganizationFeatureFlags) still validates the entire orgFeatureFlags object at once with validatePartialFeatureFlags(orgFeatureFlags):

export function mergeOrgFeatureFlags(
  globalFlags: Partial<FeatureFlagCatalog>,
  orgFeatureFlags: unknown
) {
  const parsed = orgFeatureFlags
    ? validatePartialFeatureFlags(orgFeatureFlags as Record<string, unknown>)
    : ({ success: false } as const);
  return { ...globalFlags, ...(parsed.success ? parsed.data : {}) };
}

If an org has one invalid stored flag value in Organization.featureFlags (which admin saves now keep), validatePartialFeatureFlags fails for the whole blob and mergeOrgFeatureFlags drops all of the org's valid overrides (hasWebhooksAccess, hasQueryAccess, hasLogsPageAccess, hasAiAccess, etc.), even though the admin flags dialog and /admin/api/v1/orgs/:orgId/feature-flags show them as active.

Two small related issues in FeatureFlagsDialog.tsx:

  • unsetFlag(key) only deletes next[key] without clearing derivedFlagsClearedWith(key), so unsetting runOpsMintKind leaves runOpsMintKindPrev and runOpsMintKindFlippedAt shown as set in the dialog list and JSON preview.
  • Checking "Unlock read-only flags" unlocks effect === "derived" grace-stamp rows (runOpsMintKindPrev, runOpsMintKindFlippedAt, runOpsMintShardSetPrev, runOpsMintShardSetFlippedAt) into editable controls, even though the server strips and recomputes them on save.
Reproduction repo

https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/v3/featureFlags.server.ts#L307-L314

To reproduce
  1. Call mergeOrgFeatureFlags({ hasLogsPageAccess: false }, { hasLogsPageAccess: true, realtimeBackend: "not-a-backend" }) (or save a valid flag via /admin/api/v2/orgs/:organizationId/feature-flags on an org that has an existing invalid flag).
  2. mergeOrgFeatureFlags returns { hasLogsPageAccess: false } instead of { hasLogsPageAccess: true } because validatePartialFeatureFlags fails on realtimeBackend.
Suggested fix

Use parseStoredOrgFlags(orgFeatureFlags).valid in mergeOrgFeatureFlags, and in FeatureFlagsDialog.tsx clear derivedFlagsClearedWith(key) in unsetFlag and keep effect === "derived" flags read-only when unlocked.

Additional information

No response

Image
主要語言
TypeScript
星號
16.5k
分支
1.5k
平均合併
1 天 15 小時
30 天內合併 PR
17

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

triggerdotdev/trigger.dev 的其他 Issue

查看 triggerdotdev/trigger.dev 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。