bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalid

Ouverte
  • Quelque chose ne va pas ?
#5,058 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

  • #5059 par @shafiktanbir — fermée sans fusion
  • #5070 par @MilindChatrabhuji — fermée sans fusion
  • #5086 par @ghazy2001 — fermée sans fusion

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
39/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
nextjs, typescript
Domaine
backend, frontend

Piste de recherche

Start in apps/webapp/app/v3/featureFlags.server.ts at mergeOrgFeatureFlags and inspect how stored organization flags are parsed; the reproduction shows a valid override being lost when another stored value is invalid. Then review FeatureFlagsDialog.tsx for unsetFlag and the derived grace-stamp rows. Done means valid overrides survive invalid stored values, unsetting clears related derived values, and derived rows stay read-only when unlocked; an open linked pull request indicates this work may already be underway.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Provide environment information

System:
OS: Linux 6.8 Ubuntu
Binaries:
Node: 22.14.0
pnpm: 9.15.0

Describe the bug

In a7f0f90e ("show stored org values for locked flags in the admin flags dialog"), the v1 and v2 admin org feature-flag routes were updated to read stored flags key-by-key via parseStoredOrgFlags(organization.featureFlags).valid, and saves now intentionally keep untouched invalid values and unknown keys from newer releases in Organization.featureFlags.

However, mergeOrgFeatureFlags in apps/webapp/app/v3/featureFlags.server.ts (used by resolveOrganizationFeatureFlags) still validates the entire orgFeatureFlags object at once with validatePartialFeatureFlags(orgFeatureFlags):

export function mergeOrgFeatureFlags(
  globalFlags: Partial<FeatureFlagCatalog>,
  orgFeatureFlags: unknown
) {
  const parsed = orgFeatureFlags
    ? validatePartialFeatureFlags(orgFeatureFlags as Record<string, unknown>)
    : ({ success: false } as const);
  return { ...globalFlags, ...(parsed.success ? parsed.data : {}) };
}

If an org has one invalid stored flag value in Organization.featureFlags (which admin saves now keep), validatePartialFeatureFlags fails for the whole blob and mergeOrgFeatureFlags drops all of the org's valid overrides (hasWebhooksAccess, hasQueryAccess, hasLogsPageAccess, hasAiAccess, etc.), even though the admin flags dialog and /admin/api/v1/orgs/:orgId/feature-flags show them as active.

Two small related issues in FeatureFlagsDialog.tsx:

  • unsetFlag(key) only deletes next[key] without clearing derivedFlagsClearedWith(key), so unsetting runOpsMintKind leaves runOpsMintKindPrev and runOpsMintKindFlippedAt shown as set in the dialog list and JSON preview.
  • Checking "Unlock read-only flags" unlocks effect === "derived" grace-stamp rows (runOpsMintKindPrev, runOpsMintKindFlippedAt, runOpsMintShardSetPrev, runOpsMintShardSetFlippedAt) into editable controls, even though the server strips and recomputes them on save.
Reproduction repo

https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/v3/featureFlags.server.ts#L307-L314

To reproduce
  1. Call mergeOrgFeatureFlags({ hasLogsPageAccess: false }, { hasLogsPageAccess: true, realtimeBackend: "not-a-backend" }) (or save a valid flag via /admin/api/v2/orgs/:organizationId/feature-flags on an org that has an existing invalid flag).
  2. mergeOrgFeatureFlags returns { hasLogsPageAccess: false } instead of { hasLogsPageAccess: true } because validatePartialFeatureFlags fails on realtimeBackend.
Suggested fix

Use parseStoredOrgFlags(orgFeatureFlags).valid in mergeOrgFeatureFlags, and in FeatureFlagsDialog.tsx clear derivedFlagsClearedWith(key) in unsetFlag and keep effect === "derived" flags read-only when unlocked.

Additional information

No response

Image
Langage dominant
TypeScript
Étoiles
16.5k
Forks
1.5k
Merge moyen
1 j 15 h
PR mergées (30 j)
17

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de triggerdotdev/trigger.dev

Toutes les issues de triggerdotdev/trigger.dev

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.